Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: build/android/pylib/instrumentation/test_runner.py

Issue 706203003: Update from https://crrev.com/303153 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | build/android/pylib/utils/device_temp_file.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/test_runner.py
diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py
index ebd2c83515d96bd7d7e59bd264d4642d23fc72ba..3bac503b0659cd52b091897d6ef70df5b71e27a4 100644
--- a/build/android/pylib/instrumentation/test_runner.py
+++ b/build/android/pylib/instrumentation/test_runner.py
@@ -185,6 +185,9 @@ class TestRunner(base_test_runner.BaseTestRunner):
self._SetupIndividualTestTimeoutScale(test)
self.tool.SetupEnvironment()
+ if self.flags and self._IsFreTest(test):
+ self.flags.RemoveFlags(['--disable-fre'])
+
# Make sure the forwarder is still running.
self._RestartHttpServerForwarderIfNecessary()
@@ -196,6 +199,18 @@ class TestRunner(base_test_runner.BaseTestRunner):
self.coverage_host_file = os.path.join(
self.coverage_dir, coverage_basename)
+ def _IsFreTest(self, test):
+ """Determines whether a test is a first run experience test.
+
+ Args:
+ test: The name of the test to be checked.
+
+ Returns:
+ Whether the feature being tested is FirstRunExperience.
+ """
+ freFeature = 'Feature:FirstRunExperience'
+ return freFeature in self.test_pkg.GetTestAnnotations(test)
+
def _IsPerfTest(self, test):
"""Determines whether a test is a performance test.
@@ -238,6 +253,9 @@ class TestRunner(base_test_runner.BaseTestRunner):
self.TearDownPerfMonitoring(test)
+ if self.flags and self._IsFreTest(test):
+ self.flags.AddFlags(['--disable-fre'])
+
if self.coverage_dir:
self.device.PullFile(
self.coverage_device_file, self.coverage_host_file)
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | build/android/pylib/utils/device_temp_file.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698