Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 706203003: Update from https://crrev.com/303153 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/test/spawned_test_server/local_test_server_win.cc ('k') | net/tools/quic/quic_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index e3b9ef89b2060f5b01f23b3d6df6fbbf98d41c86..55e2d88456508e90080483ca1df5368c299ef295 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -940,11 +940,11 @@ TEST_P(EndToEndTest, LimitCongestionWindowAndRTT) {
const QuicSentPacketManager& server_sent_packet_manager =
*GetSentPacketManagerFromFirstServerSession();
- // The client shouldn't set it's initial window based on the negotiated value.
- EXPECT_EQ(kDefaultInitialWindow * kDefaultTCPMSS,
- client_sent_packet_manager.GetCongestionWindow());
- EXPECT_EQ(kMaxInitialWindow * kDefaultTCPMSS,
- server_sent_packet_manager.GetCongestionWindow());
+ // The client shouldn't set its initial window based on the negotiated value.
+ EXPECT_EQ(kDefaultInitialWindow,
+ client_sent_packet_manager.GetCongestionWindowInTcpMss());
+ EXPECT_EQ(kMaxInitialWindow,
+ server_sent_packet_manager.GetCongestionWindowInTcpMss());
EXPECT_EQ(GetParam().use_pacing, server_sent_packet_manager.using_pacing());
EXPECT_EQ(GetParam().use_pacing, client_sent_packet_manager.using_pacing());
@@ -987,18 +987,17 @@ TEST_P(EndToEndTest, MaxInitialRTT) {
QuicSession* session = dispatcher->session_map().begin()->second;
const QuicSentPacketManager& client_sent_packet_manager =
client_->client()->session()->connection()->sent_packet_manager();
- const QuicSentPacketManager& server_sent_packet_manager =
- session->connection()->sent_packet_manager();
// Now that acks have been exchanged, the RTT estimate has decreased on the
// server and is not infinite on the client.
EXPECT_FALSE(
- client_sent_packet_manager.GetRttStats()->SmoothedRtt().IsInfinite());
+ client_sent_packet_manager.GetRttStats()->smoothed_rtt().IsInfinite());
+ const RttStats& server_rtt_stats =
+ *session->connection()->sent_packet_manager().GetRttStats();
EXPECT_EQ(static_cast<int64>(kMaxInitialRoundTripTimeUs),
- server_sent_packet_manager.GetRttStats()->initial_rtt_us());
- EXPECT_GE(
- static_cast<int64>(kMaxInitialRoundTripTimeUs),
- server_sent_packet_manager.GetRttStats()->SmoothedRtt().ToMicroseconds());
+ server_rtt_stats.initial_rtt_us());
+ EXPECT_GE(static_cast<int64>(kMaxInitialRoundTripTimeUs),
+ server_rtt_stats.smoothed_rtt().ToMicroseconds());
server_thread_->Resume();
}
@@ -1024,7 +1023,7 @@ TEST_P(EndToEndTest, MinInitialRTT) {
// Now that acks have been exchanged, the RTT estimate has decreased on the
// server and is not infinite on the client.
EXPECT_FALSE(
- client_sent_packet_manager.GetRttStats()->SmoothedRtt().IsInfinite());
+ client_sent_packet_manager.GetRttStats()->smoothed_rtt().IsInfinite());
// Expect the default rtt of 100ms.
EXPECT_EQ(static_cast<int64>(100 * base::Time::kMicrosecondsPerMillisecond),
server_sent_packet_manager.GetRttStats()->initial_rtt_us());
« no previous file with comments | « net/test/spawned_test_server/local_test_server_win.cc ('k') | net/tools/quic/quic_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698