Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 706193003: [WebGL-chromium]Test to validate glinfo when webglcontext fails. (Closed)

Created:
6 years, 1 month ago by sivag
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Webgl-chromium] Test to validate glinfo when webglcontext fails. Now we read the GPU(Vendor,Renderer,Driver info) from chromium side and send it as part of status message when EventTypeNames::webglcontextcreationerror is being sent. This patch introduces the test for the above functionality. forceNextWebGLContextCreationToFail(bool) is introduced to fail the webgl context forcefully from JS-test runner utility. The below cl uses the test-runner code in this patch https://codereview.chromium.org/706193003/ BUG=412400 Committed: https://crrev.com/3ccb614464d1ae6af89cbf02a028ef9f492df300 Cr-Commit-Position: refs/heads/master@{#304143}

Patch Set 1 #

Patch Set 2 : Fix for build error. #

Total comments: 2

Patch Set 3 : Changed code as per review comments. #

Total comments: 12

Patch Set 4 : Changed function signature. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M content/shell/renderer/test_runner/test_runner.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 2 3 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
sivag
ptal..
6 years, 1 month ago (2014-11-10 13:45:31 UTC) #2
Ken Russell (switch to Gerrit)
Aside from this comment the change generally looks good. Please make this update and re-upload ...
6 years, 1 month ago (2014-11-10 19:52:15 UTC) #3
sivag
@tkent, ptal. https://codereview.chromium.org/706193003/diff/20001/content/shell/renderer/test_runner/test_runner.h File content/shell/renderer/test_runner/test_runner.h (right): https://codereview.chromium.org/706193003/diff/20001/content/shell/renderer/test_runner/test_runner.h#newcode595 content/shell/renderer/test_runner/test_runner.h:595: void forceNextWebGLContextCreationToFail(bool); On 2014/11/10 19:52:14, Ken Russell ...
6 years, 1 month ago (2014-11-11 12:50:57 UTC) #5
tkent
On 2014/11/11 12:50:57, Sikugu wrote: > @tkent, ptal. This and 703903002 depend on each other. ...
6 years, 1 month ago (2014-11-12 00:17:44 UTC) #6
tkent
https://codereview.chromium.org/706193003/diff/40001/content/shell/renderer/test_runner/test_runner.cc File content/shell/renderer/test_runner/test_runner.cc (right): https://codereview.chromium.org/706193003/diff/40001/content/shell/renderer/test_runner/test_runner.cc#newcode311 content/shell/renderer/test_runner/test_runner.cc:311: void forceNextWebGLContextCreationToFail(); force -> Force https://codereview.chromium.org/706193003/diff/40001/content/shell/renderer/test_runner/test_runner.cc#newcode550 content/shell/renderer/test_runner/test_runner.cc:550: &TestRunnerBindings::forceNextWebGLContextCreationToFail) force ...
6 years, 1 month ago (2014-11-12 00:19:18 UTC) #7
sivag
ptal.. https://codereview.chromium.org/706193003/diff/40001/content/shell/renderer/test_runner/test_runner.cc File content/shell/renderer/test_runner/test_runner.cc (right): https://codereview.chromium.org/706193003/diff/40001/content/shell/renderer/test_runner/test_runner.cc#newcode311 content/shell/renderer/test_runner/test_runner.cc:311: void forceNextWebGLContextCreationToFail(); On 2014/11/12 00:19:17, tkent wrote: > ...
6 years, 1 month ago (2014-11-12 18:47:21 UTC) #8
Ken Russell (switch to Gerrit)
LGTM - but note I'm not an OWNER.
6 years, 1 month ago (2014-11-12 22:09:05 UTC) #9
tkent
lgtm
6 years, 1 month ago (2014-11-13 23:34:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706193003/60001
6 years, 1 month ago (2014-11-13 23:39:07 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-14 01:55:26 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 01:57:34 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3ccb614464d1ae6af89cbf02a028ef9f492df300
Cr-Commit-Position: refs/heads/master@{#304143}

Powered by Google App Engine
This is Rietveld 408576698