gpu/command_buffer/service/feature_info.cc - Issue 706173005: Enable asynchronous glReadPixels on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/feature_info.cc

Issue 706173005: Enable asynchronous glReadPixels on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add mechanism to propagate service-side glMapBuffer errors + tests. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/feature_info.cc

diff --git a/gpu/command_buffer/service/feature_info.cc b/gpu/command_buffer/service/feature_info.cc

index 24e1f9295f11889354c132af2cd7a87eb5a4c452..9ac35abe70beeee4f812847c2a3c00b747a877fb 100644

--- a/gpu/command_buffer/service/feature_info.cc

+++ b/gpu/command_buffer/service/feature_info.cc

@@ -855,12 +855,14 @@ void FeatureInfo::InitializeFeatures() {

UMA_HISTOGRAM_BOOLEAN("GPU.FenceSupport", ui_gl_fence_works);

feature_flags_.map_buffer_range =

- is_es3 || extensions.Contains("GL_ARB_map_buffer_range");

+ is_es3 || extensions.Contains("GL_ARB_map_buffer_range") ||

+ extensions.Contains("GL_EXT_map_buffer_range");

// Really it's part of core OpenGL 2.1 and up, but let's assume the

// extension is still advertised.

bool has_pixel_buffers =

- is_es3 || extensions.Contains("GL_ARB_pixel_buffer_object");

+ is_es3 || extensions.Contains("GL_ARB_pixel_buffer_object") ||

+ extensions.Contains("GL_NV_pixel_buffer_object");

// We will use either glMapBuffer() or glMapBufferRange() for async readbacks.

if (has_pixel_buffers && ui_gl_fence_works &&