Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 706153002: [fsp] Promote file system provider to stable. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Promote file system provider to stable. This patch cleans up the IDL and promotes the API to stable. TEST=browser_tests: *FileSystemProvider* BUG=248427 Committed: https://crrev.com/4d752f9dc097c5f1f08e610aabbe2abf475d4072 Cr-Commit-Position: refs/heads/master@{#303975}

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : Fixed compile bugs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_internal.idl View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
mtomasz
6 years, 1 month ago (2014-11-07 02:30:02 UTC) #2
mtomasz
@benwells: PTAL. Thanks.
6 years, 1 month ago (2014-11-07 02:30:11 UTC) #3
benwells
On 2014/11/07 02:30:11, mtomasz wrote: > @benwells: PTAL. Thanks. Why is this going to be ...
6 years, 1 month ago (2014-11-09 21:13:38 UTC) #4
mtomasz
On 2014/11/09 21:13:38, benwells wrote: > On 2014/11/07 02:30:11, mtomasz wrote: > > @benwells: PTAL. ...
6 years, 1 month ago (2014-11-09 23:28:57 UTC) #5
benwells
On 2014/11/09 23:28:57, mtomasz wrote: > On 2014/11/09 21:13:38, benwells wrote: > > On 2014/11/07 ...
6 years, 1 month ago (2014-11-10 21:12:53 UTC) #6
mtomasz
@benwells: I just got L G T M the security reviewer. I promoted the API ...
6 years, 1 month ago (2014-11-11 06:03:47 UTC) #7
benwells
lgtm, but please update the summary to be "Promote file system provider to stable", and ...
6 years, 1 month ago (2014-11-12 21:18:51 UTC) #8
mtomasz
On 2014/11/12 21:18:51, benwells wrote: > lgtm, but please update the summary to be "Promote ...
6 years, 1 month ago (2014-11-13 01:29:35 UTC) #9
benwells
slgtm
6 years, 1 month ago (2014-11-13 02:33:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706153002/40001
6 years, 1 month ago (2014-11-13 02:34:46 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-13 03:26:40 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-13 03:27:26 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4d752f9dc097c5f1f08e610aabbe2abf475d4072
Cr-Commit-Position: refs/heads/master@{#303975}

Powered by Google App Engine
This is Rietveld 408576698