- Fix string conversion warnings.

runtime/platform/assert.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef PLATFORM_ASSERT_H_
 #define PLATFORM_ASSERT_H_
 
 // TODO(5411406): include sstream for now, once we have a Utils::toString()
 // implemented for all the primitive types we can replace the usage of
 // sstream by Utils::toString()
@@ skipping 277 matching lines @@
 template <bool>
 struct CompileAssert {
 };
 
 #define COMPILE_ASSERT(expr, msg)                                              \
   DART_UNUSED typedef CompileAssert<(static_cast<bool>(expr))>                 \
   msg[static_cast<bool>(expr) ? 1 : -1]
 
 
 #if defined(TESTING)
+
+// EXPECT and FAIL are equivalent to ASSERT and FATAL except that they do not
+// cause early termination of the unit test. This allows testing to proceed
+// further to be able to report other failures before reporting the overall
+// unit tests as failing.
+
 #define EXPECT(condition)                                                      \
   if (!(condition)) {                                                          \
     dart::Expect(__FILE__, __LINE__).Fail("expected: %s", #condition);         \
   }
 
 #define EXPECT_EQ(expected, actual)                                            \
   dart::Expect(__FILE__, __LINE__).Equals((expected), (actual))
 
 #define EXPECT_NE(not_expected, actual)                                        \
   dart::Expect(__FILE__, __LINE__).NotEquals((not_expected), (actual))
@@ skipping 17 matching lines @@
   dart::Expect(__FILE__, __LINE__).LessEqual((left), (right))
 
 #define EXPECT_GT(left, right)                                                 \
   dart::Expect(__FILE__, __LINE__).GreaterThan((left), (right))
 
 #define EXPECT_GE(left, right)                                                 \
   dart::Expect(__FILE__, __LINE__).GreaterEqual((left), (right))
 
 #define EXPECT_NOTNULL(ptr)                                                    \
   dart::Expect(__FILE__, __LINE__).NotNull((ptr))
-#endif
 
-// TODO(iposva): provide a better way to get extra info on an EXPECT
-// fail - you suggested EXPECT_EQ(expected, actual, msg_format,
-// parameters_for_msg...), I quite like the google3 method
-// EXPECT_EQ(a, b) << "more stuff here...". (benl).
-
-#define WARN(error)                                                           \
+#define FAIL(error)                                                            \
   dart::Expect(__FILE__, __LINE__).Fail("%s", error)
 
-#define WARN1(format, p1)                                                     \
+#define FAIL1(format, p1)                                                      \
   dart::Expect(__FILE__, __LINE__).Fail(format, (p1))
 
-#define WARN2(format, p1, p2)                                                 \
+#define FAIL2(format, p1, p2)                                                  \
   dart::Expect(__FILE__, __LINE__).Fail(format, (p1), (p2))
 
+#endif  // defined(TESTING)
+
 #endif  // PLATFORM_ASSERT_H_