sky/engine/core/events/EventTarget.h - Issue 706123005: Remove nop ScriptWrappable::init calls

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/events/EventTarget.h

Issue 706123005: Remove nop ScriptWrappable::init calls (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/events/EventTarget.h

diff --git a/sky/engine/core/events/EventTarget.h b/sky/engine/core/events/EventTarget.h

index 89152ca68fe2e528912455787e1c7ebbea2f074d..d9747e4f9b7c873fd951ce7b998c880554577b80 100644

--- a/sky/engine/core/events/EventTarget.h

+++ b/sky/engine/core/events/EventTarget.h

@@ -76,8 +76,6 @@ public:

// - Figure out if you now need to inherit from ActiveDOMObject as well.

// - In your class declaration, you will typically use

// REFCOUNTED_EVENT_TARGET(YourClassName).

-// - Call ScriptWrappable::init(this) in your constructor, unless you are already

-// doing so.

// - Override EventTarget::interfaceName() and executionContext(). The former

// will typically return EventTargetNames::YourClassName. The latter will

// return ActiveDOMObject::executionContext (if you are an ActiveDOMObject)

« no previous file with comments | « sky/engine/core/events/Event.cpp ('k') | sky/engine/core/events/EventTarget.cpp » ('j') | no next file with comments »