Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 706093002: Remove <picture> and <source>. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : ojan review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -462 lines) Patch
M sky/engine/core/core.gni View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.h View 3 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.cpp View 1 5 chunks +14 lines, -80 lines 0 comments Download
D sky/engine/core/html/HTMLPictureElement.h View 1 chunk +0 lines, -28 lines 0 comments Download
D sky/engine/core/html/HTMLPictureElement.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/engine/core/html/HTMLPictureElement.idl View 1 chunk +0 lines, -10 lines 0 comments Download
D sky/engine/core/html/HTMLSourceElement.h View 1 chunk +0 lines, -75 lines 0 comments Download
D sky/engine/core/html/HTMLSourceElement.cpp View 1 chunk +0 lines, -184 lines 0 comments Download
D sky/engine/core/html/HTMLSourceElement.idl View 1 chunk +0 lines, -37 lines 0 comments Download
M sky/engine/core/html/HTMLTagNames.in View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/loader/ImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
lgtm https://codereview.chromium.org/706093002/diff/1/sky/engine/core/html/HTMLImageElement.cpp File sky/engine/core/html/HTMLImageElement.cpp (right): https://codereview.chromium.org/706093002/diff/1/sky/engine/core/html/HTMLImageElement.cpp#newcode450 sky/engine/core/html/HTMLImageElement.cpp:450: if (!foundURL) { Nit: you don't need this ...
6 years, 1 month ago (2014-11-06 23:00:59 UTC) #1
esprehn
6 years, 1 month ago (2014-11-06 23:03:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8c0d840df1f67e109160d60c25f29b5fe410e4aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698