Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 706073002: [ServiceWorker] Add Cache.put tests for URL fragment handling. (Closed)

Created:
6 years, 1 month ago by asanka
Modified:
6 years, 1 month ago
Reviewers:
jsbell
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@cleanup-formatting
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add Cache.put tests for URL fragment handling. Also toss in a test for handling URLs with embedded credentials. BUG=374802, 428970 R=jsbell Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184942

Patch Set 1 #

Total comments: 4

Patch Set 2 : Simplify tests #

Patch Set 3 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -35 lines) Patch
A LayoutTests/http/tests/serviceworker/cache-put-expected.txt View 1 1 chunk +19 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js View 1 2 8 chunks +92 lines, -35 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
asanka
6 years, 1 month ago (2014-11-06 21:51:49 UTC) #1
jsbell
lgtm with nits https://codereview.chromium.org/706073002/diff/1/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js File LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js (right): https://codereview.chromium.org/706073002/diff/1/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js#newcode6 LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js:6: // Construct a generic Request object. ...
6 years, 1 month ago (2014-11-06 22:48:37 UTC) #2
asanka
https://codereview.chromium.org/706073002/diff/1/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js File LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js (right): https://codereview.chromium.org/706073002/diff/1/LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js#newcode6 LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js:6: // Construct a generic Request object. The URL is ...
6 years, 1 month ago (2014-11-06 23:42:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/706073002/40001
6 years, 1 month ago (2014-11-07 00:41:17 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 02:08:51 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as 184942

Powered by Google App Engine
This is Rietveld 408576698