[Android WebView] Implement SmartClipProvider.

[Android WebView] Implement SmartClipProvider.

Makes AwContents implement the SmartClipProvider interface. For now,
we implement in the same way that ContentView. AwContents may have
an arbitrary container view, so this allows that container view to
invoke the smart clip methods.

Committed: https://crrev.com/de1d85133418eaffbf2cc429683e46fa1f9fc03a
Cr-Commit-Position: refs/heads/master@{#303208}

[benm (inactive), 2014-11-06 10:26:48]

benm@chromium.org changed reviewers:
+ changwan@chromium.org, torne@chromium.org

[benm (inactive), 2014-11-06 10:26:48]

ptal

[Torne, 2014-11-06 10:57:51]

lgtm

[Changwan Ryu, 2014-11-06 23:41:57]

On 2014/11/06 10:57:51, Torne wrote:
> lgtm

lgtm

[boliu, 2014-11-07 01:12:23]

https://codereview.chromium.org/705933002/diff/1/android_webview/java/src/org...
File android_webview/java/src/org/chromium/android_webview/AwContents.java
(right):

https://codereview.chromium.org/705933002/diff/1/android_webview/java/src/org...
android_webview/java/src/org/chromium/android_webview/AwContents.java:85: public
class AwContents implements SmartClipProvider {
drive-by suggestion: pull this out into a helper class rather than tag things
directly onto AwContents?

[benm (inactive), 2014-11-07 07:52:49]

Thanks Bo - agree, but will clean up in a follow up. Would like to
synchronise this with what's downstream first.

On Fri, 7 Nov 2014 01:12 null <boliu@chromium.org> wrote:

>
> https://codereview.chromium.org/705933002/diff/1/android_
> webview/java/src/org/chromium/android_webview/AwContents.java
> File
> android_webview/java/src/org/chromium/android_webview/AwContents.java
> (right):
>
> https://codereview.chromium.org/705933002/diff/1/android_
> webview/java/src/org/chromium/android_webview/AwContents.java#newcode85
> android_webview/java/src/org/chromium/android_webview/AwContents.java:85
>
<https://codereview.chromium.org/705933002/diff/1/android_webview/java/src/org...>
> :
> public class AwContents implements SmartClipProvider {
> drive-by suggestion: pull this out into a helper class rather than tag
> things directly onto AwContents?
>
> https://codereview.chromium.org/705933002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[benm (inactive), 2014-11-07 08:01:40]

The CQ bit was checked by benm@chromium.org

[commit-bot: I haz the power, 2014-11-07 08:02:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/705933002/1

[commit-bot: I haz the power, 2014-11-07 08:47:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-07 08:48:01]

Patchset 1 (id:??) landed as
https://crrev.com/de1d85133418eaffbf2cc429683e46fa1f9fc03a
Cr-Commit-Position: refs/heads/master@{#303208}