Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 705913002: WebRTC: Skip flakiness dashboard generation for memory tools bots. (Closed)

Created:
6 years, 1 month ago by kjellander_chromium
Modified:
6 years, 1 month ago
Reviewers:
ajm
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

WebRTC: Skip flakiness dashboard generation for memory tools bots. In https://codereview.chromium.org/687863002 all bots were configured to generate gtest json output during test execution. This generated errors on the Dr Memory and Memcheck bots. This CL excludes them from generating this data. TBR=ajm@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292864

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -145 lines) Patch
M scripts/slave/recipe_modules/webrtc/api.py View 1 chunk +2 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json View 16 chunks +0 lines, -48 lines 1 comment Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_full.json View 16 chunks +0 lines, -48 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_light.json View 16 chunks +0 lines, -48 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705913002/1
6 years, 1 month ago (2014-11-06 06:24:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as 292864
6 years, 1 month ago (2014-11-06 06:24:58 UTC) #4
ajm
6 years, 1 month ago (2014-11-06 06:54:24 UTC) #5
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/705913002/diff/1/scripts/slave/recipes/webrtc...
File
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json
(left):

https://codereview.chromium.org/705913002/diff/1/scripts/slave/recipes/webrtc...
scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json:100:
"gtest-results/audio_decoder_unittests",
Just curious: was this only generating flakiness results for this test?

Powered by Google App Engine
This is Rietveld 408576698