Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 7059014: ARM: Fix wrong value returned from keyed property assignemnt (Closed) Base URL: http://v8.googlecode.com/svn/branches/3.1/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/version.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 7215 matching lines...) Expand 10 before | Expand all | Expand 10 after
7226 MemOperand(scratch1, key, LSL, 7226 MemOperand(scratch1, key, LSL,
7227 kPointerSizeLog2 - (kSmiTagSize + kSmiShiftSize))); 7227 kPointerSizeLog2 - (kSmiTagSize + kSmiShiftSize)));
7228 7228
7229 // Make sure that the expected number of instructions are generated. 7229 // Make sure that the expected number of instructions are generated.
7230 ASSERT_EQ(kInlinedKeyedStoreInstructionsAfterPatch, 7230 ASSERT_EQ(kInlinedKeyedStoreInstructionsAfterPatch,
7231 masm_->InstructionsGeneratedSince(&check_inlined_codesize)); 7231 masm_->InstructionsGeneratedSince(&check_inlined_codesize));
7232 } 7232 }
7233 7233
7234 ASSERT(we_remembered_the_write_barrier); 7234 ASSERT(we_remembered_the_write_barrier);
7235 7235
7236 // Make sure that r0 holds the value which is the result of the expression.
7237 __ Move(r0, value);
7238
7236 deferred->BindExit(); 7239 deferred->BindExit();
7237 } else { 7240 } else {
7238 frame()->CallKeyedStoreIC(strict_mode_flag()); 7241 frame()->CallKeyedStoreIC(strict_mode_flag());
7239 } 7242 }
7240 } 7243 }
7241 7244
7242 7245
7243 #ifdef DEBUG 7246 #ifdef DEBUG
7244 bool CodeGenerator::HasValidEntryRegisters() { return true; } 7247 bool CodeGenerator::HasValidEntryRegisters() { return true; }
7245 #endif 7248 #endif
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
7396 BinaryOpIC::GetName(runtime_operands_type_)); 7399 BinaryOpIC::GetName(runtime_operands_type_));
7397 return name_; 7400 return name_;
7398 } 7401 }
7399 7402
7400 7403
7401 #undef __ 7404 #undef __
7402 7405
7403 } } // namespace v8::internal 7406 } } // namespace v8::internal
7404 7407
7405 #endif // V8_TARGET_ARCH_ARM 7408 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698