Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: pdf/BUILD.gn

Issue 705823002: Add pdf layer code for PDFium XFA module (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Indent Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/pdf.gyp » ('j') | pdf/pdf.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/BUILD.gn
diff --git a/pdf/BUILD.gn b/pdf/BUILD.gn
index 5e1f165b1c3fef9dfb4d30147f679f9dd9143572..70591c131277aa955811758bac012893b2a5ceca 100644
--- a/pdf/BUILD.gn
+++ b/pdf/BUILD.gn
@@ -3,6 +3,7 @@
# found in the LICENSE file.
pdf_engine = 0 # 0 PDFium
+pdf_use_xfa = 0
# TODO(GYP) need support for loadable modules
shared_library("pdf") {
@@ -65,6 +66,10 @@ shared_library("pdf") {
]
}
+ if(pdf_use_xfa == 1) {
Lei Zhang 2014/11/06 04:08:08 nit: space after if
+ defines += [ "_PDF_USE_XFA_" ]
Lei Zhang 2014/11/06 04:08:08 You need to start with: defines = [] after sourc
Bo Xu 2014/11/06 05:43:51 Done.
Lei Zhang 2014/11/06 19:15:29 You need to write it like: defines = [] if (condi
+ }
+
if (is_win) {
defines = [ "COMPILE_CONTENT_STATICALLY" ]
cflags = [ "/wd4267" ] # TODO(jschuh) size_t to int truncations.
« no previous file with comments | « no previous file | pdf/pdf.gyp » ('j') | pdf/pdf.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698