Source/core/css/resolver/StyleResolverState.cpp - Issue 705783002: Decouple font unit conversion in computeLengthDouble from RenderStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleResolverState.cpp

Issue 705783002: Decouple font unit conversion in computeLengthDouble from RenderStyle. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed timloh's issues. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSToLengthConversionData.h ('K') | « Source/core/css/resolver/StyleResolverState.h ('k') | Source/core/css/resolver/ViewportStyleResolver.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/resolver/StyleResolverState.cpp

diff --git a/Source/core/css/resolver/StyleResolverState.cpp b/Source/core/css/resolver/StyleResolverState.cpp

index b71a93d26e0c468e25faaac22a6ba6c964247016..798235740821e8c7b162749a717639b1cfa21564 100644

--- a/Source/core/css/resolver/StyleResolverState.cpp

+++ b/Source/core/css/resolver/StyleResolverState.cpp

@@ -33,7 +33,6 @@ StyleResolverState::StyleResolverState(Document& document, Element* element, Ren

: m_elementContext(element ? ElementResolveContext(*element) : ElementResolveContext(document))

, m_document(document)

, m_style(nullptr)

- , m_cssToLengthConversionData(0, rootElementStyle(), document.renderView())

Timothy Loh 2014/11/07 17:59:38 We're going to re-add this and remove the default

andersr 2014/11/08 01:39:45 Yes, that was the plan. (Various setStyle function

, m_parentStyle(parentStyle)

, m_applyPropertyToRegularStyle(true)

, m_applyPropertyToVisitedLinkStyle(false)