Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: Source/core/css/resolver/StyleBuilderConverter.cpp

Issue 705783002: Decouple font unit conversion in computeLengthDouble from RenderStyle. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed timloh's issues. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/Source/core/css/resolver/StyleBuilderConverter.cpp b/Source/core/css/resolver/StyleBuilderConverter.cpp
index dadc1ec303a7ca5137b07683f4f382574e585638..46de8a4fb4837513da85e9760d24884a146b2178 100644
--- a/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -189,29 +189,14 @@ PassRefPtr<FontFeatureSettings> StyleBuilderConverter::convertFontFeatureSetting
return settings;
}
-class RedirectSetHasViewportUnits {
-public:
- RedirectSetHasViewportUnits(RenderStyle* from, RenderStyle* to)
- : m_from(from), m_to(to), m_hadViewportUnits(from->hasViewportUnits())
- {
- from->setHasViewportUnits(false);
- }
- ~RedirectSetHasViewportUnits()
- {
- m_to->setHasViewportUnits(m_from->hasViewportUnits());
- m_from->setHasViewportUnits(m_hadViewportUnits);
- }
-private:
- RenderStyle* m_from;
- RenderStyle* m_to;
- bool m_hadViewportUnits;
-};
-
static float computeFontSize(StyleResolverState& state, CSSPrimitiveValue* primitiveValue, const FontDescription::Size& parentSize)
{
- RedirectSetHasViewportUnits redirect(state.parentStyle(), state.style());
+ float em = state.parentStyle()->specifiedFontSize();
+ float rem = state.rootElementStyle()->specifiedFontSize();
+ CSSToLengthConversionData::FontSizes fontSizes(em, rem, &state.parentStyle()->font());
+ CSSToLengthConversionData::ViewportSize viewportSize(state.document().renderView());
- CSSToLengthConversionData conversionData(state.parentStyle(), state.rootElementStyle(), state.document().renderView(), 1.0f, true);
+ CSSToLengthConversionData conversionData(state.style(), fontSizes, viewportSize, 1.0f);
if (primitiveValue->isLength())
return primitiveValue->computeLength<float>(conversionData);
if (primitiveValue->isCalculatedPercentageWithLength())

Powered by Google App Engine
This is Rietveld 408576698