Decouple font unit conversion in computeLengthDouble from RenderStyle.

Source/core/css/resolver/StyleBuilderConverter.cpp

Index: Source/core/css/resolver/StyleBuilderConverter.cpp
diff --git a/Source/core/css/resolver/StyleBuilderConverter.cpp b/Source/core/css/resolver/StyleBuilderConverter.cpp
index dadc1ec303a7ca5137b07683f4f382574e585638..cbc2a52275126b3b34c2089616a2fd262b691ff0 100644
--- a/Source/core/css/resolver/StyleBuilderConverter.cpp
+++ b/Source/core/css/resolver/StyleBuilderConverter.cpp
@@ -189,29 +189,14 @@ PassRefPtr<FontFeatureSettings> StyleBuilderConverter::convertFontFeatureSetting
     return settings;
 }
 
-class RedirectSetHasViewportUnits {
-public:
-    RedirectSetHasViewportUnits(RenderStyle* from, RenderStyle* to)
-        : m_from(from), m_to(to), m_hadViewportUnits(from->hasViewportUnits())
-    {
-        from->setHasViewportUnits(false);
-    }
-    ~RedirectSetHasViewportUnits()
-    {
-        m_to->setHasViewportUnits(m_from->hasViewportUnits());
-        m_from->setHasViewportUnits(m_hadViewportUnits);
-    }
-private:
-    RenderStyle* m_from;
-    RenderStyle* m_to;
-    bool m_hadViewportUnits;
-};
-
 static float computeFontSize(StyleResolverState& state, CSSPrimitiveValue* primitiveValue, const FontDescription::Size& parentSize)
 {
-    RedirectSetHasViewportUnits redirect(state.parentStyle(), state.style());
+    float em = state.parentStyle()->specifiedFontSize();
+    float rem = state.rootElementStyle() ? state.rootElementStyle()->specifiedFontSize() : 1.0f;

[Timothy Loh, 2014/11/06 16:24:00]

As mentioned elsewhere, I think we always have a root style.

[andersr, 2014/11/07 10:43:11]

Done.

+    CSSToLengthFontSizes fontSizes(em, rem, &state.parentStyle()->font());
+    CSSToLengthViewportSize viewportSize(state.document().renderView());
 
-    CSSToLengthConversionData conversionData(state.parentStyle(), state.rootElementStyle(), state.document().renderView(), 1.0f, true);
+    CSSToLengthConversionData conversionData(state.style(), fontSizes, viewportSize, 1.0f);
     if (primitiveValue->isLength())
         return primitiveValue->computeLength<float>(conversionData);
     if (primitiveValue->isCalculatedPercentageWithLength())