Source/core/css/CSSCalculationValueTest.cpp - Issue 705783002: Decouple font unit conversion in computeLengthDouble from RenderStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValueTest.cpp

Issue 705783002: Decouple font unit conversion in computeLengthDouble from RenderStyle. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Forgot to remove ASSERT(rootStyle). Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSCalculationValueTest.cpp

diff --git a/Source/core/css/CSSCalculationValueTest.cpp b/Source/core/css/CSSCalculationValueTest.cpp

index b3e553024f1cb8a7809c0e7e4d6c9a4a5413dfb1..14476a8462b42e813fe1b57e5417b9b5338a7b03 100644

--- a/Source/core/css/CSSCalculationValueTest.cpp

+++ b/Source/core/css/CSSCalculationValueTest.cpp

@@ -91,7 +91,7 @@ TEST(CSSCalculationValue, AccumulatePixelsAndPercent)

{

RefPtr<RenderStyle> style = RenderStyle::createDefaultStyle();

style->setEffectiveZoom(5);

- CSSToLengthConversionData conversionData(style.get(), style.get(), 0);

+ CSSToLengthConversionData conversionData(style.get(), style.get(), nullptr, style->effectiveZoom());

testAccumulatePixelsAndPercent(conversionData,

CSSCalcValue::createExpressionNode(CSSPrimitiveValue::create(10, CSSPrimitiveValue::CSS_PX), true),

« no previous file with comments | « no previous file | Source/core/css/CSSGradientValue.cpp » ('j') | no next file with comments »