LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html - Issue 705733002: Make sure that selection is cleared after tapping.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html

Issue 705733002: Make sure that selection is cleared after tapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../../resources/js-test.js"></script>

	3 <body>
	Rick Byers 2014/11/13 20:09:01 nit: omit <body> (it's unnecessary and you have no nit: omit <body> (it's unnecessary and you have no matching </body> anyway).
	4 <div id="dragme">Make Selection Here</div>

	5 <p id="description"></p>
	Rick Byers 2014/11/13 20:09:01 nit: you can also omit this <p> and the blow conso nit: you can also omit this <p> and the blow console <div> - js-test.js will add them for you.
	6 <div id="console"></div>

	7 <script>

	8 description("This tests if the selection is reset after tapping of gesture");

	9

	10 var dragme = document.getElementById('dragme');

	11 var reselt;
	Rick Byers 2014/11/13 20:09:01 note this is mis-spelled. note this is mis-spelled.
	12 if (window.eventSender) {

	13 var startX = dragme.offsetLeft;

	14 var startY = dragme.offsetTop;

	15

	16 var endX = dragme.offsetLeft + dragme.offsetWidth;

	17 var endY = dragme.offsetTop + dragme.offsetHeight;

	18

	19 eventSender.mouseMoveTo(startX, startY);

	20 eventSender.mouseDown();

	21 eventSender.leapForward(200);

	22 eventSender.mouseMoveTo(endX, endY);

	23 eventSender.mouseUp();
	Rick Byers 2014/11/13 20:09:01 Could this test be simpler by setting the selectio Could this test be simpler by setting the selection explicitly in JavaScript instead of simulating mouse events? This is OK too, but it might be slightly easier for you to maintain. Also please test that the selection rangeCount is actually >0 BEFORE sending the tap. Otherwise a simple test (or product) bug that resulted in a total lack of selection would look like a perfectly valid 'SUCCESS':-(
	24

	25 eventSender.gestureTap(startX + dragme.offsetWidth / 2, startY + dragme.offs etHeight / 2);
	Rick Byers 2014/11/13 20:09:01 we're trying to start to enforce (with ASSERTs) th we're trying to start to enforce (with ASSERTs) that events come in valid streams (eg. see http://crbug.com/345372). Tap is only valid after a GestureTapDown and GestureShowPress, so please send those first (see other tests in this directory as an example).
	26

	27 result = window.getSelection().rangeCount > 0 ? 'FAILED' : 'SUCCESS';
	Rick Byers 2014/11/13 20:09:01 no need for the temporary 'result'. Just do a sho no need for the temporary 'result'. Just do a shouldBeGreaterThan(window.getSelection()...).
	28 shouldBeEqualToString('result', 'SUCCESS');

	29 }

	30 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range-expected.txt » ('j') | no next file with comments »