Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: chrome/common/net/gaia/gaia_authenticator.cc

Issue 7057053: Escaping file names correctly. Also fixed a crush in chromeos debug build while saving a web page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missed fix. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/net/gaia/gaia_auth_fetcher.cc ('k') | chrome/common/net/gaia/gaia_oauth_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/net/gaia/gaia_authenticator.cc
diff --git a/chrome/common/net/gaia/gaia_authenticator.cc b/chrome/common/net/gaia/gaia_authenticator.cc
index 36d060e12c3f83859b613abb0cd36e7cc7531b62..fa16c06c0fe05d4a0e98292d9ab5633f7fe72a17 100644
--- a/chrome/common/net/gaia/gaia_authenticator.cc
+++ b/chrome/common/net/gaia/gaia_authenticator.cc
@@ -158,13 +158,15 @@ bool GaiaAuthenticator::PerformGaiaRequest(const AuthParams& params,
GURL gaia_auth_url(gaia_url_);
string post_body;
- post_body += "Email=" + EscapeUrlEncodedData(params.email);
- post_body += "&Passwd=" + EscapeUrlEncodedData(params.password);
- post_body += "&source=" + EscapeUrlEncodedData(user_agent_);
+ post_body += "Email=" + EscapeUrlEncodedData(params.email, true);
+ post_body += "&Passwd=" + EscapeUrlEncodedData(params.password, true);
+ post_body += "&source=" + EscapeUrlEncodedData(user_agent_, true);
post_body += "&service=" + service_id_;
if (!params.captcha_token.empty() && !params.captcha_value.empty()) {
- post_body += "&logintoken=" + EscapeUrlEncodedData(params.captcha_token);
- post_body += "&logincaptcha=" + EscapeUrlEncodedData(params.captcha_value);
+ post_body += "&logintoken=" +
+ EscapeUrlEncodedData(params.captcha_token, true);
+ post_body += "&logincaptcha=" +
+ EscapeUrlEncodedData(params.captcha_value, true);
}
post_body += "&PersistentCookie=true";
// We set it to GOOGLE (and not HOSTED or HOSTED_OR_GOOGLE) because we only
@@ -215,7 +217,7 @@ bool GaiaAuthenticator::LookupEmail(AuthResults* results) {
string post_body;
post_body += "LSID=";
- post_body += EscapeUrlEncodedData(results->lsid);
+ post_body += EscapeUrlEncodedData(results->lsid, true);
unsigned long server_response_code;
string message_text;
@@ -265,7 +267,7 @@ bool GaiaAuthenticator::IssueAuthToken(AuthResults* results,
string post_body;
post_body += "LSID=";
- post_body += EscapeUrlEncodedData(results->lsid);
+ post_body += EscapeUrlEncodedData(results->lsid, true);
post_body += "&service=" + service_id;
post_body += "&Session=true";
« no previous file with comments | « chrome/common/net/gaia/gaia_auth_fetcher.cc ('k') | chrome/common/net/gaia/gaia_oauth_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698