Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 705703002: Remove mojo/tools/, not needed in chromium (Closed)

Created:
6 years, 1 month ago by jamesr
Modified:
6 years, 1 month ago
Reviewers:
sky, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove mojo/tools/, not needed in chromium R=sky@chromium.org Committed: https://crrev.com/d27b8840552bff045a35852d94ea45ed4cbc8686 Cr-Commit-Position: refs/heads/master@{#302758}

Patch Set 1 #

Patch Set 2 : remove gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1577 lines) Patch
M mojo/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/mojo_base.gyp View 1 2 chunks +0 lines, -17 lines 0 comments Download
D mojo/tools/BUILD.gn View 1 chunk +0 lines, -23 lines 0 comments Download
D mojo/tools/check_mojom_golden_files.py View 1 chunk +0 lines, -103 lines 0 comments Download
D mojo/tools/data/unittests View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/tools/generate_java_callback_interfaces.py View 1 chunk +0 lines, -69 lines 0 comments Download
D mojo/tools/message_generator.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/tools/mojob.sh View 1 chunk +0 lines, -205 lines 0 comments Download
D mojo/tools/mojosh.sh View 1 chunk +0 lines, -71 lines 0 comments Download
D mojo/tools/package_manager/BUILD.gn View 1 chunk +0 lines, -29 lines 0 comments Download
D mojo/tools/package_manager/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/tools/package_manager/manifest.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/tools/package_manager/manifest.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/tools/package_manager/package_fetcher.h View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/tools/package_manager/package_fetcher.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D mojo/tools/package_manager/package_manager.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/tools/package_manager/package_manager_application.h View 1 chunk +0 lines, -63 lines 0 comments Download
D mojo/tools/package_manager/package_manager_application.cc View 1 chunk +0 lines, -113 lines 0 comments Download
D mojo/tools/package_manager/unpacker.h View 1 chunk +0 lines, -40 lines 0 comments Download
D mojo/tools/package_manager/unpacker.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/tools/pylib/mojo_python_tests_runner.py View 1 chunk +0 lines, -147 lines 0 comments Download
D mojo/tools/pylib/transitive_hash.py View 1 chunk +0 lines, -89 lines 0 comments Download
D mojo/tools/run_mojo_python_bindings_tests.py View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/tools/run_mojo_python_tests.py View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/tools/test_runner.py View 1 chunk +0 lines, -116 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
jamesr
6 years, 1 month ago (2014-11-05 00:51:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705703002/20001
6 years, 1 month ago (2014-11-05 01:28:52 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-05 01:28:57 UTC) #5
viettrungluu
lgtm
6 years, 1 month ago (2014-11-05 01:31:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705703002/20001
6 years, 1 month ago (2014-11-05 01:34:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8689)
6 years, 1 month ago (2014-11-05 03:07:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705703002/20001
6 years, 1 month ago (2014-11-05 05:10:20 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 05:41:50 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 05:43:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d27b8840552bff045a35852d94ea45ed4cbc8686
Cr-Commit-Position: refs/heads/master@{#302758}

Powered by Google App Engine
This is Rietveld 408576698