Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 705663002: Add GYP_INCLUDE_FIRST/LAST to chromium.gyp_env (Closed)

Created:
6 years, 1 month ago by justsomeguy
Modified:
6 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add GYP_INCLUDE_FIRST/LAST to chromium.gyp_env This allows us to override the settings in common.gypi, as well as other include files. Only accepts one string, not an array. Limitation of gyp_helper. BUG= Committed: https://crrev.com/cec083d3e7038a5b26e5fdc2e514d404890805cb Cr-Commit-Position: refs/heads/master@{#302841}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed debug print #

Patch Set 3 : python script to allow gyp to read gni file lists #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -0 lines) Patch
A build/gni_to_gyp.py View 1 2 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Mark Mentovai
LGTM otherwise https://codereview.chromium.org/705663002/diff/1/build/gyp_chromium File build/gyp_chromium (right): https://codereview.chromium.org/705663002/diff/1/build/gyp_chromium#newcode181 build/gyp_chromium:181: print "add first", os.environ.get('GYP_INCLUDE_FIRST') Remove this line.
6 years, 1 month ago (2014-11-04 22:28:23 UTC) #4
justsomeguy
Removed the print
6 years, 1 month ago (2014-11-04 23:23:47 UTC) #5
Mark Mentovai
LGTM
6 years, 1 month ago (2014-11-04 23:25:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705663002/20001
6 years, 1 month ago (2014-11-05 00:59:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/8677)
6 years, 1 month ago (2014-11-05 02:21:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705663002/20001
6 years, 1 month ago (2014-11-05 18:28:38 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 18:57:22 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 18:58:05 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cec083d3e7038a5b26e5fdc2e514d404890805cb
Cr-Commit-Position: refs/heads/master@{#302841}

Powered by Google App Engine
This is Rietveld 408576698