Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 705623004: GN: Get os="chromeos" use_ozone=true to compile (Closed)

Created:
6 years, 1 month ago by Dirk Pranke
Modified:
6 years, 1 month ago
Reviewers:
Chris Masone
CC:
chromium-reviews, ozone-reviews_chromium.org, sadrul, tdresser+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: Get os="chromeos" use_ozone=true to compile There were a number of ozone targets that had rusted or never been implemented in the GN build for Chrome OS. Fix it! R=cmasone TBR=brettw BUG=424334 TEST=build chrome with os=chromeos use_ozone=true use_clang=true Committed: https://crrev.com/acd282e852c15ea7b3dd1d09252dbe9f66578f2c Cr-Commit-Position: refs/heads/master@{#302752}

Patch Set 1 : initial patch from cl/699063002 #

Patch Set 2 : more fixes, build chrome and app_shell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -39 lines) Patch
M ash/BUILD.gn View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chromeos/BUILD.gn View 1 2 chunks +6 lines, -1 line 0 comments Download
M content/common/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/aura/BUILD.gn View 2 chunks +9 lines, -5 lines 0 comments Download
M ui/base/BUILD.gn View 2 chunks +7 lines, -10 lines 0 comments Download
M ui/display/BUILD.gn View 1 1 chunk +8 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/ozone/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
A + ui/ozone/gpu/BUILD.gn View 1 chunk +6 lines, -10 lines 0 comments Download
M ui/views/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Dirk Pranke
6 years, 1 month ago (2014-11-05 02:33:54 UTC) #2
Chris Masone
lgtm! Let's get this on a bot so it stops regressing...
6 years, 1 month ago (2014-11-05 02:42:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705623004/20001
6 years, 1 month ago (2014-11-05 03:10:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22203)
6 years, 1 month ago (2014-11-05 03:15:03 UTC) #7
Dirk Pranke
tbr'ing brett for an OWNERS approval.
6 years, 1 month ago (2014-11-05 03:37:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705623004/20001
6 years, 1 month ago (2014-11-05 03:38:24 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 03:54:55 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 03:55:34 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/acd282e852c15ea7b3dd1d09252dbe9f66578f2c
Cr-Commit-Position: refs/heads/master@{#302752}

Powered by Google App Engine
This is Rietveld 408576698