Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 705623003: Fix test_sky in release builds (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Fix test_sky in release builds This CL passes the configuration information from test_sky to sky_server so that sky_server can find the correct output directory. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5674d85ecf070b442f4ae80c4169000f5af9e439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -41 lines) Patch
M sky/tools/sky_server View 3 chunks +8 lines, -4 lines 0 comments Download
M sky/tools/skydb View 5 chunks +8 lines, -5 lines 0 comments Download
A sky/tools/skypy/configuration.py View 1 chunk +15 lines, -0 lines 0 comments Download
M sky/tools/skypy/paths.py View 1 chunk +8 lines, -8 lines 0 comments Download
M sky/tools/test_perf View 3 chunks +21 lines, -24 lines 0 comments Download
M sky/tools/webkitpy/layout_tests/port/base.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-05 01:17:26 UTC) #1
eseidel
lgtm
6 years, 1 month ago (2014-11-05 01:20:03 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-11-05 01:20:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5674d85ecf070b442f4ae80c4169000f5af9e439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698