content/public/renderer/pepper_plugin_instance.h - Issue 705623002: Initialize V8 in PDFium from external files (in-renderer process only).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/renderer/pepper_plugin_instance.h

Issue 705623002: Initialize V8 in PDFium from external files (in-renderer process only). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from Ross and Raymes Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/pdf/renderer/ppb_pdf_impl.cc ('K') | « content/content_tests.gypi ('k') | content/renderer/pepper/fake_pepper_plugin_instance.h » ('j') | content/renderer/pepper/fake_pepper_plugin_instance.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/renderer/pepper_plugin_instance.h

diff --git a/content/public/renderer/pepper_plugin_instance.h b/content/public/renderer/pepper_plugin_instance.h

index d397fbc2ad0108695175ab244c67eae37e018de7..f5db1181ee5a5e88e44d9036672411d2b8e9f55d 100644

--- a/content/public/renderer/pepper_plugin_instance.h

+++ b/content/public/renderer/pepper_plugin_instance.h

@@ -117,6 +117,13 @@ class PepperPluginInstance {

// Posts a message to the JavaScript object for this instance.

virtual void PostMessageToJavaScript(PP_Var message) = 0;

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

raymes 2014/11/10 03:29:06 nit: we can get rid of this ifdef

baixo1 2014/11/10 15:59:48 Done.

+ virtual void GetV8ExternalSnapshotData(const char** natives_data_out,

+ int* natives_size_out,

+ const char** snapshot_data_out,

+ int* snapshot_size_out) const = 0;

+#endif

};

} // namespace content