build/common.gypi - Issue 705623002: Initialize V8 in PDFium from external files (in-renderer process only).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 705623002: Initialize V8 in PDFium from external files (in-renderer process only). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments from Ross and Raymes Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 5ebf3f41d6274d767123b99fb523c877c2df9152..1e872f3bb2e7921c782a475a52e3704d0f1e56ea 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1015,10 +1015,10 @@

'optimize_jni_generation%': 0,

}],

- # TODO(baixo): Enable v8_use_external_startup_data

+ # TODO(baixo): Enable v8_use_external_startup_data for Windows and Mac -

# http://crbug.com/421063

- ['android_webview_build==0 and android_webview_telemetry_build==0 and chromecast==0', {

- 'v8_use_external_startup_data': 0,

+ ['android_webview_build==0 and android_webview_telemetry_build==0 and chromecast==0 and (OS=="android" or OS=="linux")', {

rmcilroy 2014/11/07 23:46:00 Please remove this change from this CL

+ 'v8_use_external_startup_data': 1,

}, {

'v8_use_external_startup_data': 0,

}],

« no previous file with comments | « no previous file | components/pdf/renderer/ppb_pdf_impl.cc » ('j') | components/pdf/renderer/ppb_pdf_impl.cc » ('J')