Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: ppapi/cpp/private/pdf.cc

Issue 705623002: Initialize V8 in PDFium from external files (in-renderer process only). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments from Ross and Raymes Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« ppapi/cpp/private/pdf.h ('K') | « ppapi/cpp/private/pdf.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ppapi/cpp/private/pdf.h" 5 #include "ppapi/cpp/private/pdf.h"
6 6
7 #include "ppapi/c/trusted/ppb_browser_font_trusted.h" 7 #include "ppapi/c/trusted/ppb_browser_font_trusted.h"
8 #include "ppapi/cpp/image_data.h" 8 #include "ppapi/cpp/image_data.h"
9 #include "ppapi/cpp/instance_handle.h" 9 #include "ppapi/cpp/instance_handle.h"
10 #include "ppapi/cpp/module_impl.h" 10 #include "ppapi/cpp/module_impl.h"
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 selected_text); 190 selected_text);
191 } 191 }
192 } 192 }
193 193
194 // static 194 // static
195 void PDF::SetLinkUnderCursor(const InstanceHandle& instance, const char* url) { 195 void PDF::SetLinkUnderCursor(const InstanceHandle& instance, const char* url) {
196 if (has_interface<PPB_PDF>()) 196 if (has_interface<PPB_PDF>())
197 get_interface<PPB_PDF>()->SetLinkUnderCursor(instance.pp_instance(), url); 197 get_interface<PPB_PDF>()->SetLinkUnderCursor(instance.pp_instance(), url);
198 } 198 }
199 199
200 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
raymes 2014/11/10 03:29:06 same here
baixo1 2014/11/10 15:59:49 Done.
201 // static
202 void PDF::GetV8ExternalSnapshotData(const InstanceHandle& instance,
203 const char** natives_data_out,
204 int* natives_size_out,
205 const char** snapshot_data_out,
206 int* snapshot_size_out) {
207 if (has_interface<PPB_PDF>()) {
208 get_interface<PPB_PDF>()->GetV8ExternalSnapshotData(instance.pp_instance(),
209 natives_data_out,
210 natives_size_out,
211 snapshot_data_out,
212 snapshot_size_out);
213 return;
214 }
215 *natives_data_out = *snapshot_data_out = NULL;
216 *natives_size_out = *snapshot_size_out = 0;
raymes 2014/11/10 03:29:07 nit: same here please break up this line
baixo1 2014/11/10 15:59:49 Done.
217 }
218 #endif
219
200 } // namespace pp 220 } // namespace pp
OLDNEW
« ppapi/cpp/private/pdf.h ('K') | « ppapi/cpp/private/pdf.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698