Initialize V8 in PDFium from external files (in-renderer process only).

gin/isolate_holder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gin/public/isolate_holder.h"
 
 #include <stdlib.h>
 #include <string.h>
 
 #include "base/logging.h"
@@ skipping 26 matching lines @@
 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
 base::MemoryMappedFile* g_mapped_natives = NULL;
 base::MemoryMappedFile* g_mapped_snapshot = NULL;
 
 bool MapV8Files(base::FilePath* natives_path, base::FilePath* snapshot_path,
                 int natives_fd = -1, int snapshot_fd = -1) {
   int flags = base::File::FLAG_OPEN | base::File::FLAG_READ;
 
   g_mapped_natives = new base::MemoryMappedFile;
   if (!g_mapped_natives->IsValid()) {
+#ifdef OS_ANDROID

[rmcilroy, 2014/11/07 23:46:00]

Why does MapV8Files need changing here? Doesn't the old approach of checking
natives_fd work any longer?

[baixo1, 2014/11/10 15:59:48]

Yes, it does work. I undid the changes.

     if (natives_fd == -1
         ? !g_mapped_natives->Initialize(base::File(*natives_path, flags))
-        : !g_mapped_natives->Initialize(base::File(natives_fd))) {
+        : !g_mapped_natives->Initialize(base::File(natives_fd))
+#else
+    if (!g_mapped_natives->Initialize(base::File(*natives_path, flags))
+#endif
+      ) {
       delete g_mapped_natives;
       g_mapped_natives = NULL;
       LOG(FATAL) << "Couldn't mmap v8 natives data file";
       return false;
     }
   }
 
   g_mapped_snapshot = new base::MemoryMappedFile;
   if (!g_mapped_snapshot->IsValid()) {
+#ifdef OS_ANDROID
     if (snapshot_fd == -1
         ? !g_mapped_snapshot->Initialize(base::File(*snapshot_path, flags))
-        : !g_mapped_snapshot->Initialize(base::File(snapshot_fd))) {
+        : !g_mapped_snapshot->Initialize(base::File(snapshot_fd))
+#else
+    if (!g_mapped_snapshot->Initialize(base::File(*snapshot_path, flags))
+#endif
+      ) {
       delete g_mapped_snapshot;
       g_mapped_snapshot = NULL;
       LOG(ERROR) << "Couldn't mmap v8 snapshot data file";
       return false;
     }
   }
 
   return true;
 }
 #endif  // V8_USE_EXTERNAL_STARTUP_DATA
 
 }  // namespace
 
 
 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
 // static
 bool IsolateHolder::LoadV8Snapshot() {
   if (g_mapped_natives && g_mapped_snapshot)
     return true;
 
   base::FilePath data_path;
-  PathService::Get(base::DIR_ANDROID_APP_DATA, &data_path);
+  PathService::Get(
+#if defined(OS_ANDROID)
+    base::DIR_ANDROID_APP_DATA,
+#elif defined(OS_POSIX)
+    base::DIR_EXE,
+#endif
+    &data_path);
   DCHECK(!data_path.empty());
 
   base::FilePath natives_path = data_path.AppendASCII("natives_blob.bin");
   base::FilePath snapshot_path = data_path.AppendASCII("snapshot_blob.bin");
 
   return MapV8Files(&natives_path, &snapshot_path);
 }
 
+#ifdef OS_ANDROID

[rmcilroy, 2014/11/07 23:46:01]

Why ifdef OS_ANDROID here?  Ideally we should keep ifdefs to a minimum unless
there is a good reason for them.

[baixo1, 2014/11/10 15:59:48]

Done.

 //static
 bool IsolateHolder::LoadV8SnapshotFD(int natives_fd, int snapshot_fd) {
   if (g_mapped_natives && g_mapped_snapshot)
     return true;
 
   return MapV8Files(NULL, NULL, natives_fd, snapshot_fd);
 }
+#endif  // OS_ANDROID
+
+#ifndef OS_ANDROID

[rmcilroy, 2014/11/07 23:46:01]

why ifndef OS_ANDROID here?  I know we aren't calling it on android currently
but I don't see why it wouldn't work for Android?

[baixo1, 2014/11/10 15:59:48]

Done.

+//static
+void IsolateHolder::GetV8ExternalSnapshotData(const char** natives_data_out,
+                                              int* natives_size_out,
+                                              const char** snapshot_data_out,
+                                              int* snapshot_size_out) {
+  if (!g_mapped_natives || !g_mapped_snapshot) {
+    *natives_data_out = *snapshot_data_out = NULL;
+    *natives_size_out = *snapshot_size_out = 0;
+    return;
+  }
+  *natives_data_out = reinterpret_cast<const char*>(g_mapped_natives->data());
+  *snapshot_data_out = reinterpret_cast<const char*>(g_mapped_snapshot->data());
+  *natives_size_out = g_mapped_natives->length();
+  *snapshot_size_out = g_mapped_snapshot->length();
+}
+#endif  // OS_ANDROID
+
 #endif  // V8_USE_EXTERNAL_STARTUP_DATA
 
 IsolateHolder::IsolateHolder() {
   CHECK(g_array_buffer_allocator)
       << "You need to invoke gin::IsolateHolder::Initialize first";
   v8::Isolate::CreateParams params;
   params.entry_hook = DebugImpl::GetFunctionEntryHook();
   params.code_event_handler = DebugImpl::GetJitCodeEventHandler();
   params.constraints.ConfigureDefaults(base::SysInfo::AmountOfPhysicalMemory(),
                                        base::SysInfo::AmountOfVirtualMemory(),
@@ skipping 69 matching lines @@
   base::MessageLoop::current()->AddTaskObserver(task_observer_.get());
 }
 
 void IsolateHolder::RemoveRunMicrotasksObserver() {
   DCHECK(task_observer_.get());
   base::MessageLoop::current()->RemoveTaskObserver(task_observer_.get());
   task_observer_.reset();
 }
 
 }  // namespace gin