Initialize V8 in PDFium from external files (in-renderer process only).

content/renderer/pepper/pepper_plugin_instance_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 121 matching lines @@
 #if defined(OS_CHROMEOS)
 #include "ui/events/keycodes/keyboard_codes_posix.h"
 #endif
 
 #if defined(OS_WIN)
 #include "base/metrics/histogram.h"
 #include "base/win/windows_version.h"
 #include "skia/ext/platform_canvas.h"
 #endif
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+#include "gin/public/isolate_holder.h"
+#endif
+
 using base::StringPrintf;
 using ppapi::InputEventData;
 using ppapi::PpapiGlobals;
 using ppapi::PPB_InputEvent_Shared;
 using ppapi::PPB_View_Shared;
 using ppapi::PPP_Instance_Combined;
 using ppapi::Resource;
 using ppapi::ScopedPPResource;
 using ppapi::ScopedPPVar;
 using ppapi::StringVar;
@@ skipping 1278 matching lines @@
 void PepperPluginInstanceImpl::SetTextInputType(ui::TextInputType type) {
   text_input_type_ = type;
   render_frame_->PepperTextInputTypeChanged(this);
 }
 
 void PepperPluginInstanceImpl::PostMessageToJavaScript(PP_Var message) {
   if (message_channel_)
     message_channel_->PostMessageToJavaScript(message);
 }
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

[raymes, 2014/11/10 03:29:06]

You can move the #ifdef into the function and return error values if it isn't
defined, e.g.

#ifdef V8_USE_EXTERNAL_STARTUP_DATA
gin::IsolateHolder::GetV8ExternalSnapshotData(natives_data_out,
natives_size_out, snapshot_data_out, snapshot_size_out);
#else
*natives_data_out = ...;
...
#endif

[baixo1, 2014/11/10 15:59:48]

Done.

[baixo1, 2014/11/10 17:16:49]

Better yet, I made gin handle this :)

+void PepperPluginInstanceImpl::GetV8ExternalSnapshotData(
+                                const char** natives_data_out,
+                                int* natives_size_out,
+                                const char** snapshot_data_out,
+                                int* snapshot_size_out) const {

[raymes, 2014/11/10 03:29:06]

nit: the indentation looks wrong here. I think you just want 4 spaces from the
left.

[baixo1, 2014/11/10 15:59:48]

Done.

+  gin::IsolateHolder::GetV8ExternalSnapshotData(natives_data_out,
+                                                natives_size_out,
+                                                snapshot_data_out,
+                                                snapshot_size_out);
+}
+#endif
+
 int32_t PepperPluginInstanceImpl::RegisterMessageHandler(
     PP_Instance instance,
     void* user_data,
     const PPP_MessageHandler_0_2* handler,
     PP_Resource message_loop) {
   // Not supported in-process.
   NOTIMPLEMENTED();
   return PP_ERROR_FAILED;
 }
 
@@ skipping 1916 matching lines @@
     return;
 
   is_peripheral_content_ = false;
   power_saver_enabled_ = false;
   SetPluginThrottled(false);
 
   RecordUnthrottleMethodMetric(UNTHROTTLE_METHOD_BY_WHITELIST);
 }
 
 }  // namespace content