Initialize V8 in PDFium from external files (in-renderer process only).

components/pdf/renderer/ppb_pdf_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/pdf/renderer/ppb_pdf_impl.h"
 
 #include "base/files/scoped_file.h"
 #include "base/metrics/histogram.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 311 matching lines @@
 }
 
 void SetLinkUnderCursor(PP_Instance instance_id, const char* url) {
   content::PepperPluginInstance* instance =
       content::PepperPluginInstance::Get(instance_id);
   if (!instance)
     return;
   instance->SetLinkUnderCursor(url);
 }
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+void GetV8ExternalSnapshotData(PP_Instance instance_id,
+                               const char** natives_data_out,
+                               int* natives_size_out,
+                               const char** snapshot_data_out,
+                               int* snapshot_size_out) {
+  content::PepperPluginInstance* instance =
+      content::PepperPluginInstance::Get(instance_id);
+  if (!instance) {
+    *natives_data_out = *snapshot_data_out = NULL;
+    *natives_size_out = *snapshot_size_out = 0;

[raymes, 2014/11/10 03:29:06]

nit: I don't know if this style is common. I'd rather the more verbose version
here with separate lines for each variable :)

[baixo1, 2014/11/10 15:59:47]

Done.

+    return;
+  }
+  instance->GetV8ExternalSnapshotData(natives_data_out, natives_size_out,
+                                      snapshot_data_out, snapshot_size_out);
+}
+#endif
+
 const PPB_PDF ppb_pdf = {                      //
     &GetLocalizedString,                       //
     &GetResourceImage,                         //
     &GetFontFileWithFallback,                  //
     &GetFontTableForPrivateFontFile,           //
     &SearchString,                             //
     &DidStartLoading,                          //
     &DidStopLoading,                           //
     &SetContentRestriction,                    //
     &HistogramPDFPageCount,                    //
     &UserMetricsRecordAction,                  //
     &HasUnsupportedFeature,                    //
     &SaveAs,                                   //
     &Print,                                    //
     &IsFeatureEnabled,                         //
     &GetResourceImageForScale,                 //
     &ModalPromptForPassword,                   //
     &IsOutOfProcess,                           //
     &SetSelectedText,                          //
     &SetLinkUnderCursor,                       //
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

[rmcilroy, 2014/11/07 23:46:00]

I don't think you need the ifdef here - it's fine to have the API unconditinally
and only actually call the API if V8_USE_EXTERNAL_STARTUP_DATA I think (unless
Raymes disagrees).

[raymes, 2014/11/10 03:29:06]

+1 We can get rid of the #ifdef above too and bury the #ifdef inside the
implementation in the deepest place possible (either in
pepper_plugin_instance_impl.cc or in gin somewhere which would be my
preference).

[baixo1, 2014/11/10 15:59:47]

Removed both this and the other one above (function definition).

+    &GetV8ExternalSnapshotData,                //
+#endif
 };
 
 }  // namespace
 
 // static
 const PPB_PDF* PPB_PDF_Impl::GetInterface() {
   return &ppb_pdf;
 }
 
 // static
 bool PPB_PDF_Impl::InvokePrintingForInstance(PP_Instance instance_id) {
   return g_print_client ? g_print_client->Print(instance_id) : false;
 }
 
 void PPB_PDF_Impl::SetPrintClient(PPB_PDF_Impl::PrintClient* client) {
   CHECK(!g_print_client) << "There should only be a single PrintClient.";
   g_print_client = client;
 }
 
 }  // namespace pdf