Initialize V8 in PDFium from external files (in-renderer process only).

pdf/instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/instance.h"
 
 #include <algorithm>  // for min()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 28 matching lines @@
 #include "ppapi/cpp/private/pdf.h"
 #include "ppapi/cpp/rect.h"
 #include "ppapi/cpp/resource.h"
 #include "ppapi/cpp/url_request_info.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 
 #if defined(OS_MACOSX)
 #include "base/mac/mac_util.h"
 #endif
 
+#if !defined(OS_ANDROID) && defined(V8_USE_EXTERNAL_STARTUP_DATA)

[raymes, 2014/11/04 22:18:13]

*You should be able to get rid of all the OS_ANDROID ifdefs everywhere - plugins
aren't built for android at all.
*What is the reason for having the V8_USE_EXTERNAL_STARTUP_DATA ifdef?

[baixo1, 2014/11/07 21:35:34]

Done.
The feature is not enabled on all platforms yet (like Mac and Windows, for
instance).

+#include "v8/include/v8.h"

[raymes, 2014/11/04 22:18:13]

I just want to make sure - does pdfium use this same header (just making sure
we're using the same copy of v8 as the one used in pdfium)

[baixo1, 2014/11/07 21:35:34]

According to Lei, this file is part of pdf.dll, which contains the V8 copy used
by pdfium (otherwise we shouldn't set V8's snapshot data here either).

[raymes, 2014/11/10 03:29:05]

That sounds right to me. Thanks!

+#endif
+
 namespace chrome_pdf {
 
 struct ToolbarButtonInfo {
   uint32 id;
   Button::ButtonStyle style;
   PP_ResourceImage normal;
   PP_ResourceImage highlighted;
   PP_ResourceImage pressed;
 };
 
@@ skipping 253 matching lines @@
     timer_factory_.CancelAll();
     timer_pending_ = false;
   }
   // The engine may try to access this instance during its destruction.
   // Make sure this happens early while the instance is still intact.
   engine_.reset();
   RemovePerInstanceObject(kPPPPdfInterface, this);
 }
 
 bool Instance::Init(uint32_t argc, const char* argn[], const char* argv[]) {
+#if !defined(OS_ANDROID) && defined(V8_USE_EXTERNAL_STARTUP_DATA)
+  v8::StartupData natives;
+  natives.data = pp::PDF::GetV8NativesData(this);
+  natives.raw_size = pp::PDF::GetV8NativesSize(this);
+  natives.compressed_size = pp::PDF::GetV8NativesSize(this);
+  v8::V8::SetNativesDataBlob(&natives);
+
+  v8::StartupData snapshot;
+  snapshot.data = pp::PDF::GetV8SnapshotData(this);
+  snapshot.raw_size = pp::PDF::GetV8SnapshotSize(this);
+  snapshot.compressed_size = pp::PDF::GetV8SnapshotSize(this);
+  v8::V8::SetSnapshotDataBlob(&snapshot);
+#endif  // !defined(OS_ANDROID) && defined(V8_USE_EXTERNAL_STARTUP_DATA)
+
   // For now, we hide HiDPI support behind a flag.
   if (pp::PDF::IsFeatureEnabled(this, PP_PDFFEATURE_HIDPI))
     hidpi_enabled_ = true;
 
   printing_enabled_ = pp::PDF::IsFeatureEnabled(this, PP_PDFFEATURE_PRINTING);
   if (printing_enabled_) {
     CreateToolbar(kPDFToolbarButtons, arraysize(kPDFToolbarButtons));
   } else {
     CreateToolbar(kPDFNoPrintToolbarButtons,
                   arraysize(kPDFNoPrintToolbarButtons));
@@ skipping 2439 matching lines @@
   return instance_->HasScriptableMethod(name, exception);
 }
 
 pp::Var PDFScriptableObject::Call(const pp::Var& method,
                                   const std::vector<pp::Var>& args,
                                   pp::Var* exception) {
   return instance_->CallScriptableMethod(method, args, exception);
 }
 
 }  // namespace chrome_pdf