Initialize V8 in PDFium from external files (in-renderer process only).

content/renderer/pepper/pepper_plugin_instance_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_plugin_instance_impl.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/command_line.h"
 #include "base/debug/trace_event.h"
@@ skipping 120 matching lines @@
 #if defined(OS_CHROMEOS)
 #include "ui/events/keycodes/keyboard_codes_posix.h"
 #endif
 
 #if defined(OS_WIN)
 #include "base/metrics/histogram.h"
 #include "base/win/windows_version.h"
 #include "skia/ext/platform_canvas.h"
 #endif
 
+#if !defined(OS_ANDROID) && defined(V8_USE_EXTERNAL_STARTUP_DATA)
+#include "gin/public/isolate_holder.h"
+#endif
+
 using base::StringPrintf;
 using ppapi::InputEventData;
 using ppapi::PpapiGlobals;
 using ppapi::PPB_InputEvent_Shared;
 using ppapi::PPB_View_Shared;
 using ppapi::PPP_Instance_Combined;
 using ppapi::Resource;
 using ppapi::ScopedPPResource;
 using ppapi::ScopedPPVar;
 using ppapi::StringVar;
@@ skipping 1249 matching lines @@
 void PepperPluginInstanceImpl::SetTextInputType(ui::TextInputType type) {
   text_input_type_ = type;
   render_frame_->PepperTextInputTypeChanged(this);
 }
 
 void PepperPluginInstanceImpl::PostMessageToJavaScript(PP_Var message) {
   if (message_channel_)
     message_channel_->PostMessageToJavaScript(message);
 }
 
+#if !defined(OS_ANDROID) && defined(V8_USE_EXTERNAL_STARTUP_DATA)
+const char* PepperPluginInstanceImpl::GetV8NativesData() const {
+  return gin::IsolateHolder::GetV8NativesData();

[raymes, 2014/11/04 22:18:13]

Can we get away with not modifying pepper_plugin_instance_impl.cc and instead
put all the implementation in ppb_pdf_impl.cc?

[baixo1, 2014/11/07 21:35:34]

I'm afraid not, Raymes.

Correct me if I'm wrong, but ppb_pdf_impl.cc seems to be the "inside the plugin"
part of the API and pepper_plugin_instance_impl.cc is the other side.


plugin -> ppb_pdf_impl  --|--> pepper_plugin_instance_impl -> gin
    INSIDE                |             OUTSIDE
                       interface

So, when we need the V8 data (this is provided by gin) from inside the plugin we
call ppb_pdf_impl.cc which, in turn, interfaces with
pepper_plugin_instance_impl.cc (the outside part) which calls gin to get the
data.

Putting "all the implementation" in ppb_pdf_impl.cc (which involves calling gin)
then mean we can access gin from inside the plugin, which then means we don't
need an API.

Am I missing anything?

[raymes, 2014/11/10 03:29:05]

No, that shouldn't be true. ppb_pdf_impl and pepper_plugin_instance_impl should
both be inside chrome.dll.

[baixo1, 2014/11/10 15:59:47]

If this is the case, then we can call gin from ppb_pdf_impl. So yes, we can put
the implementation there. We'd have to include a dependency on gin in
components/pdf though -- is it ok?

[raymes, 2014/11/11 02:40:19]

Yep that should be fine. Thanks!

+}
+
+const char* PepperPluginInstanceImpl::GetV8SnapshotData() const {
+  return gin::IsolateHolder::GetV8SnapshotData();
+}
+
+int PepperPluginInstanceImpl::GetV8NativesSize() const {
+  return gin::IsolateHolder::GetV8NativesSize();
+}
+
+int PepperPluginInstanceImpl::GetV8SnapshotSize() const {
+  return gin::IsolateHolder::GetV8SnapshotSize();
+}
+#endif  // !defined(OS_ANDROID) && defined(V8_USE_EXTERNAL_STARTUP_DATA)
+
 int32_t PepperPluginInstanceImpl::RegisterMessageHandler(
     PP_Instance instance,
     void* user_data,
     const PPP_MessageHandler_0_2* handler,
     PP_Resource message_loop) {
   // Not supported in-process.
   NOTIMPLEMENTED();
   return PP_ERROR_FAILED;
 }
 
@@ skipping 1911 matching lines @@
   SendDidChangeView();
 }
 
 void PepperPluginInstanceImpl::DisablePowerSaverAndUnthrottle() {
   DCHECK(power_saver_enabled_);
   power_saver_enabled_ = false;
   SetPluginThrottled(false);
 }
 
 }  // namespace content