Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: webkit/database/database_connections_unittest.cc

Issue 7056025: More WebSQLDatabase and QuotaManager integration. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/database/database_connections.cc ('k') | webkit/database/database_tracker.h » ('j') | webkit/database/database_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/database/database_connections_unittest.cc
===================================================================
--- webkit/database/database_connections_unittest.cc (revision 86470)
+++ webkit/database/database_connections_unittest.cc (working copy)
@@ -81,11 +81,18 @@
EXPECT_FALSE(connections.IsDatabaseOpened(kOriginId, kName2));
EXPECT_TRUE(connections.IsDatabaseOpened(kOriginId, kName));
EXPECT_EQ(kSize, connections.GetOpenDatabaseSize(kOriginId, kName));
-
+ another.RemoveAllConnections();
connections.RemoveAllConnections();
EXPECT_TRUE(connections.IsEmpty());
- another.RemoveAllConnections();
+ // Ensure the return value properly indicates the initial
+ // addition and final removal.
+ EXPECT_TRUE(connections.AddConnection(kOriginId, kName));
+ EXPECT_FALSE(connections.AddConnection(kOriginId, kName));
+ EXPECT_FALSE(connections.AddConnection(kOriginId, kName));
+ EXPECT_FALSE(connections.RemoveConnection(kOriginId, kName));
+ EXPECT_FALSE(connections.RemoveConnection(kOriginId, kName));
+ EXPECT_TRUE(connections.RemoveConnection(kOriginId, kName));
}
TEST(DatabaseConnectionsTest, DatabaseConnectionsWrapperTest) {
« no previous file with comments | « webkit/database/database_connections.cc ('k') | webkit/database/database_tracker.h » ('j') | webkit/database/database_tracker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698