More WebSQLDatabase and QuotaManager integration.

More WebSQLDatabase and QuotaManager integration.

1) Fix bugs with how usage and deltas in usage were being computed. The tracker was reporting confusing numbers because in some cases it was stat'ing files and in other cases it was using a value cached in memory. Now the tracker always uses a cached value for open database files, and updates the cached value when changes are noticed. During that update, delta notifications are sent.

2) Remove the old and unsed support for quota from the DatabaseTracker. Changes to the class interface rippled to various unit tests.

BUG=61676
TEST=updated existing unit tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86871

[michaeln, 2011-05-24 04:18:17]

Hi Kinuko,

I'm a little backlogged on landing changes so this one is not yet complete.
There are some .h file changes i need to make to remove notions of
'space_available' and 'quota' from this class. All of the callers no longer
depend on this class for those functions, just need to clean up the interface.

There are logic changes in here that fix the bugs that resulted in negative
usage numbers. Those changes should be unaffected by the .h file cleanup.

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_tr...
File webkit/database/database_tracker.cc (right):

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_tr...
webkit/database/database_tracker.cc:150: *database_size =
GetDBFileSize(origin_identifier, database_name);
I also need to update the size in the CachedOriginInfo record in this clause...
i intend to create a SeedOpenDatabaseSize method when i can edit the .h file
with this CL.

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_tr...
webkit/database/database_tracker.cc:155: *database_size  =
UpdateCachedDatabaseFileSize(origin_identifier,
I plan to rename this to UpdateOpenDatabaseSizeAndNotify.

[kinuko, 2011-05-24 05:31:35]

a few superficial comments

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_co...
File webkit/database/database_connections.cc (right):

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_co...
webkit/database/database_connections.cc:44: return  ++count == 1;
nit: extra space between return and ++count

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_co...
File webkit/database/database_connections.h (right):

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_co...
webkit/database/database_connections.h:31: // Returns true of this is the first
connection.
nit: of -> if?

http://codereview.chromium.org/7056025/diff/18001/webkit/quota/quota_manager.cc
File webkit/quota/quota_manager.cc (right):

http://codereview.chromium.org/7056025/diff/18001/webkit/quota/quota_manager....
webkit/quota/quota_manager.cc:88: DCHECK_GE(usage, 0);
fyi: the latest manager code can handle usage <= 0 cases.

[michaeln, 2011-05-25 01:28:06]

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_co...
File webkit/database/database_connections.cc (right):

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_co...
webkit/database/database_connections.cc:44: return  ++count == 1;
On 2011/05/24 05:31:36, kinuko wrote:
> nit: extra space between return and ++count

Done.

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_co...
File webkit/database/database_connections.h (right):

http://codereview.chromium.org/7056025/diff/18001/webkit/database/database_co...
webkit/database/database_connections.h:31: // Returns true of this is the first
connection.
On 2011/05/24 05:31:36, kinuko wrote:
> nit: of -> if?

Done.

[michaeln, 2011-05-26 00:17:26]

kinuko, i think this is the last of the SQL+Quota modulo what we do about
unlimited storage.

http://codereview.chromium.org/7056025/diff/22001/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_service_unittest.cc (right):

http://codereview.chromium.org/7056025/diff/22001/chrome/browser/extensions/e...
chrome/browser/extensions/extension_service_unittest.cc:68: #include
"webkit/database/database_util.h"
remove some includes

[kinuko, 2011-05-26 03:35:13]

LGTM

Not sure if the lengthy tracker testing code is covering all the changes but the
tracker code looks easier to follow now.

http://codereview.chromium.org/7056025/diff/15021/webkit/database/database_tr...
File webkit/database/database_tracker.cc (right):

http://codereview.chromium.org/7056025/diff/15021/webkit/database/database_tr...
webkit/database/database_tracker.cc:158:
quota_manager_proxy_->NotifyStorageAccessed(
Why are we notifying access on close?  Could we have a short comment about that?

[michaeln, 2011-05-26 03:57:31]

http://codereview.chromium.org/7056025/diff/15021/webkit/database/database_tr...
File webkit/database/database_tracker.cc (right):

http://codereview.chromium.org/7056025/diff/15021/webkit/database/database_tr...
webkit/database/database_tracker.cc:158:
quota_manager_proxy_->NotifyStorageAccessed(
On 2011/05/26 03:35:13, kinuko wrote:
> Why are we notifying access on close?  Could we have a short comment about
that?

Will do...

We only call NotifiyStorageAccessed when a db is first opened. We call
NotifyStorageModified as writes occur, but we don't have any knowledge of reads
at this level. So on close, i'm bumping the last access date to make up for
that.