Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5216)

Unified Diff: chrome/test/webdriver/commands/mouse_commands.cc

Issue 7055004: File upload API in chromedriver (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Fixed according to the code review. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/webdriver/commands/mouse_commands.cc
diff --git a/chrome/test/webdriver/commands/mouse_commands.cc b/chrome/test/webdriver/commands/mouse_commands.cc
index c331cbcd36e8d399e038671bc034ef01f8823198..d390a6d9100b5fce2ab671f07eb721f9ff85dc2d 100644
--- a/chrome/test/webdriver/commands/mouse_commands.cc
+++ b/chrome/test/webdriver/commands/mouse_commands.cc
@@ -35,27 +35,13 @@ bool ElementMouseCommand::DoesPost() {
}
void ElementMouseCommand::ExecutePost(Response* response) {
- Error* error = session_->CheckElementPreconditionsForClicking(element);
- if (error) {
- response->SetError(error);
- return;
- }
-
gfx::Point location;
- error = session_->GetElementLocationInView(element, &location);
- if (error) {
- response->SetError(error);
- return;
- }
-
- gfx::Size size;
- error = session_->GetElementSize(session_->current_target(), element, &size);
+ Error* error = session_->GetClickableLocation(element, &location);
if (error) {
response->SetError(error);
return;
}
- location.Offset(size.width() / 2, size.height() / 2);
error = Action(location);
if (error) {
response->SetError(error);

Powered by Google App Engine
This is Rietveld 408576698