Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 705433002: Deflake SimpleIndexFileTest.WriteThenLoadIndex. (Closed)

Created:
6 years, 1 month ago by gavinp
Modified:
6 years, 1 month ago
Reviewers:
jkarlin
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Deflake SimpleIndexFileTest.WriteThenLoadIndex. This test was using the wrong mtime as its reference for freshness, and the index file directory was being created in the wrong order on creation, which tended to make the first load of an index appear stale, which was particularly pernicious for a test. R=jkarlin@chromium.org BUG=255775 Committed: https://crrev.com/67e2ec660017eb124889df3400e1c2298c656e6f Cr-Commit-Position: refs/heads/master@{#302621}

Patch Set 1 #

Patch Set 2 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M net/disk_cache/simple/simple_index_file.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M net/disk_cache/simple/simple_index_file_unittest.cc View 1 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
gavinp
jkarlin: PTAL. I wanted this out of the way before proceeding with our stress test ...
6 years, 1 month ago (2014-11-03 22:03:46 UTC) #1
jkarlin
lgtm
6 years, 1 month ago (2014-11-04 16:17:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705433002/20001
6 years, 1 month ago (2014-11-04 16:20:52 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 17:14:32 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 17:15:05 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67e2ec660017eb124889df3400e1c2298c656e6f
Cr-Commit-Position: refs/heads/master@{#302621}

Powered by Google App Engine
This is Rietveld 408576698