Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 7054073: Merge 87772 - 2011-05-31 Kinuko Yasuda <kinuko@chromium.org> (Closed)

Created:
9 years, 6 months ago by kinuko
Modified:
9 years, 6 months ago
Reviewers:
kinuko
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 87772 - 2011-05-31 Kinuko Yasuda <kinuko@chromium.org>; Reviewed by Kent Tamura. [Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given. https://bugs.webkit.org/show_bug.cgi?id=61823 Added a new test for the fix marked the new test 'skipped' on unsupported platforms. * platform/chromium/test_expectations.txt: * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: * storage/storageinfo-no-callbacks-expected.txt: Added. * storage/storageinfo-no-callbacks.html: Added. 2011-05-31 Kinuko Yasuda <kinuko@chromium.org>; Reviewed by Kent Tamura. [Chromium] webkitStorageInfo methods (for quota API) should not crash when error callback is not given. https://bugs.webkit.org/show_bug.cgi?id=61823 Fixed assertion on errorCallback parameter. Test: storage/quotainfo-no-callbacks.html * src/StorageInfoChromium.cpp: (WebCore::StorageInfo::queryUsageAndQuota): (WebCore::StorageInfo::requestQuota): BUG=84527 TBR=kinuko@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -483 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +0 lines, -480 lines 0 comments Download
M LayoutTests/platform/chromium/test_expectations.txt View 1 chunk +4 lines, -3 lines 0 comments Download
M LayoutTests/platform/gtk/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/mac/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/qt/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/win/Skipped View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/storage/script-tests/storageinfo-no-callbacks.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/storage/storageinfo-no-callbacks.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/storage/storageinfo-no-callbacks-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebKit/chromium/ChangeLog View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/src/StorageInfoChromium.cpp View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kinuko
9 years, 6 months ago (2011-06-06 15:48:57 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698