Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(137)

Issue 7054067: Merge 87848 - 2011-06-01 Daniel Cheng <dcheng@chromium.org> (Closed)

Created:
8 years, 5 months ago by dcheng
Modified:
8 years, 5 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/782/
Visibility:
Public.

Description

Merge 87848 - 2011-06-01 Daniel Cheng <dcheng@chromium.org>; Reviewed by Tony Chang. [chromium] Use correct file name for dragging out images. https://bugs.webkit.org/show_bug.cgi?id=24887 * fast/events/drag-image-filename-expected.txt: Added. * fast/events/drag-image-filename.html: Added. * platform/gtk/Skipped: * platform/mac/Skipped: * platform/qt/Skipped: * platform/win/Skipped: 2011-06-01 Daniel Cheng <dcheng@chromium.org>; Reviewed by Tony Chang. [chromium] Use correct file name for dragging out images. https://bugs.webkit.org/show_bug.cgi?id=24887 We try to guess an appropriate filename when dragging out images. In order, we try to use: - The filename suggested in the HTTP header. - The last path component of the source URL. - The alt text. This matches the behavior of the other WebKit ports. Test: fast/events/drag-image-filename.html * platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject): * platform/chromium/ClipboardChromiumMac.cpp: (WebCore::isInvalidFileCharacter): (WebCore::ClipboardChromium::validateFileName): 2011-06-01 Daniel Cheng <dcheng@chromium.org>; Reviewed by Tony Chang. [chromium] Use correct file name for dragging out images. https://bugs.webkit.org/show_bug.cgi?id=24887 * DumpRenderTree/chromium/EventSender.cpp: (EventSender::EventSender): (EventSender::dumpFilenameBeingDragged): * DumpRenderTree/chromium/EventSender.h: TBR=dcheng@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -10 lines) Patch
A + LayoutTests/fast/events/drag-image-filename.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/events/drag-image-filename-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M LayoutTests/platform/gtk/Skipped View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac/Skipped View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/platform/qt/Skipped View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/Skipped View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/WebCore/platform/chromium/ClipboardChromium.cpp View 1 chunk +15 lines, -9 lines 0 comments Download
M Source/WebCore/platform/chromium/ClipboardChromiumMac.cpp View 1 chunk +31 lines, -3 lines 0 comments Download
M Tools/DumpRenderTree/chromium/EventSender.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/EventSender.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dcheng
8 years, 5 months ago (2011-06-04 17:44:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698