Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 705363003: Remove internals.profiler (Closed)

Created:
6 years, 1 month ago by Hajime Morrita
Modified:
6 years, 1 month ago
Reviewers:
haraken, tkent
CC:
blink-reviews, arv+blink, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove internals.profiler Nobody uses this anymore. R=haraken@chromium.org, tkent@chromium.org BUG=263316 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185159

Patch Set 1 #

Patch Set 2 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -214 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/harness/internals-profilers-heap.html View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/harness/internals-profilers-heap-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/core.gypi View 1 2 chunks +0 lines, -3 lines 0 comments Download
D Source/core/testing/InternalProfilers.h View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/core/testing/InternalProfilers.cpp View 1 chunk +0 lines, -68 lines 0 comments Download
D Source/core/testing/InternalProfilers.idl View 1 chunk +0 lines, -38 lines 0 comments Download
M Source/core/testing/Internals.h View 1 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/testing/Internals.cpp View 1 3 chunks +0 lines, -9 lines 0 comments Download
M Source/core/testing/Internals.idl View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/Platform.h View 1 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Hajime Morrita
6 years, 1 month ago (2014-11-08 00:44:33 UTC) #1
haraken
LGTM
6 years, 1 month ago (2014-11-08 02:36:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705363003/1
6 years, 1 month ago (2014-11-08 02:36:38 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35430)
6 years, 1 month ago (2014-11-08 03:55:28 UTC) #6
tkent
On 2014/11/08 03:55:28, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 1 month ago (2014-11-10 01:39:29 UTC) #9
gmorrita
On 2014/11/10 01:39:29, tkent wrote: > On 2014/11/08 03:55:28, I haz the power (commit-bot) wrote: ...
6 years, 1 month ago (2014-11-10 16:24:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705363003/20001
6 years, 1 month ago (2014-11-11 18:59:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/19491)
6 years, 1 month ago (2014-11-11 19:03:57 UTC) #14
Hajime Morrita
Kent-san, could you rubberstamp public/platform ? Thanks!
6 years, 1 month ago (2014-11-11 19:22:31 UTC) #15
tkent
lgtm
6 years, 1 month ago (2014-11-12 00:35:22 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705363003/20001
6 years, 1 month ago (2014-11-12 00:36:15 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 185159
6 years, 1 month ago (2014-11-12 00:40:28 UTC) #19
Hajime Morrita
6 years, 1 month ago (2014-11-12 00:56:44 UTC) #20
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698