Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 705343002: [ServiceWorker] Serialize Cache.put() calls in Cache.match tests. (Closed)

Created:
6 years, 1 month ago by asanka
Modified:
6 years, 1 month ago
Reviewers:
bkelly, jsbell
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@no-fragments
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Serialize Cache.put() calls in Cache.match tests. Also remove extraneous test cache entry. The result of inserting cache entries that have 'Vary' headers depend on the order of insertion. Make the test setup step be deterministic so that the prepopulated cache is always in a predictable state when the tests are run. R=jsbell, bkelly@mozilla.com BUG=428965, 374802, 429874 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185060

Patch Set 1 #

Patch Set 2 : Update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -159 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/cache-match-expected.txt View 1 1 chunk +33 lines, -29 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/cache-match-worker.js View 15 chunks +140 lines, -122 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
asanka
6 years, 1 month ago (2014-11-07 18:59:53 UTC) #1
jsbell
lgtm Enumeration order of object keys should be deterministic (for web-compat reasons) so I'd be ...
6 years, 1 month ago (2014-11-07 20:23:25 UTC) #2
asanka
On 2014/11/07 20:23:25, jsbell wrote: > lgtm > > Enumeration order of object keys should ...
6 years, 1 month ago (2014-11-10 19:31:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705343002/20001
6 years, 1 month ago (2014-11-10 19:37:42 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-10 20:42:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 185060

Powered by Google App Engine
This is Rietveld 408576698