Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 705303004: Remove clipRect parameter from LayerPainter::applyRoundedRectClips(). (Closed)

Created:
6 years, 1 month ago by mstensho (USE GERRIT)
Modified:
6 years, 1 month ago
Reviewers:
chrishtr
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove clipRect parameter from LayerPainter::applyRoundedRectClips(). It was only used to check if there was a radius involved, which is easy enough, and even sensible (since we can then avoid calling this method at all in most cases - after all, it's not like border radius is something you set on every other element), to check before calling the method. Additionally, this made it pretty obvious that calling this from paintTransformedLayerIntoFragments() was rather useless, since clipRect there wasn't a ClipRect but a LayoutRect (which knows nothing about radii). R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185086

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -16 lines) Patch
M Source/core/paint/LayerPainter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/LayerPainter.cpp View 7 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mstensho (USE GERRIT)
6 years, 1 month ago (2014-11-10 12:01:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705303004/1
6 years, 1 month ago (2014-11-11 01:06:28 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-11-11 01:06:30 UTC) #5
chrishtr
lgtm
6 years, 1 month ago (2014-11-11 01:08:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705303004/1
6 years, 1 month ago (2014-11-11 01:08:29 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 01:16:21 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 185086

Powered by Google App Engine
This is Rietveld 408576698