Use the WebKit default fonts when specifying generic font families.

Use the WebKit default fonts when specifying generic font families.

This pipes through a new preferences object that the font system can use.
It now picks up these faces as well as the default font size.

Clarify this behavior in the interface.

TEST=manual (font example included).
BUG=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86870

[yzshen1, 2011-05-25 23:40:10]

Hi, Brett.

It looks great, just a few nits...

http://codereview.chromium.org/7053022/diff/6003/content/renderer/pepper_plug...
File content/renderer/pepper_plugin_delegate_impl.cc (right):

http://codereview.chromium.org/7053022/diff/6003/content/renderer/pepper_plug...
content/renderer/pepper_plugin_delegate_impl.cc:1330: return
::ppapi::Preferences(render_view_->webkit_preferences());
I think here the '::' prefix is not mandatory, right?
If it is here just for readability, it might be good to keep consistent and
change other occurrences such as line 367.

http://codereview.chromium.org/7053022/diff/6003/ppapi/c/dev/ppb_font_dev.h
File ppapi/c/dev/ppb_font_dev.h (right):

http://codereview.chromium.org/7053022/diff/6003/ppapi/c/dev/ppb_font_dev.h#n...
ppapi/c/dev/ppb_font_dev.h:82: * the the user may have a different font size for
the default monospace font
Please remove one 'the' at the beginning.

http://codereview.chromium.org/7053022/diff/6003/ppapi/examples/font/simple_f...
File ppapi/examples/font/simple_font.cc (right):

http://codereview.chromium.org/7053022/diff/6003/ppapi/examples/font/simple_f...
ppapi/examples/font/simple_font.cc:96: snprintf(buf, sizeof(buf), "%s = %s
%dpt",
I think this is not defined on Windows.
You could use _snprintf on Windows (and please note that it won't set '\0' at
the end on Windows, if the buffer is not big enough).

http://codereview.chromium.org/7053022/diff/6003/ppapi/proxy/plugin_dispatche...
File ppapi/proxy/plugin_dispatcher.cc (right):

http://codereview.chromium.org/7053022/diff/6003/ppapi/proxy/plugin_dispatche...
ppapi/proxy/plugin_dispatcher.cc:23: #include
"ppapi/shared_impl/ppapi_preferences.h"
[minor]
You may not need it since it has been included by the .h file.

http://codereview.chromium.org/7053022/diff/6003/ppapi/shared_impl/ppapi_pref...
File ppapi/shared_impl/ppapi_preferences.cc (right):

http://codereview.chromium.org/7053022/diff/6003/ppapi/shared_impl/ppapi_pref...
ppapi/shared_impl/ppapi_preferences.cc:11: Preferences::Preferences() {
Is it necessary to initialize those int members?

http://codereview.chromium.org/7053022/diff/6003/webkit/plugins/ppapi/webkit_...
File webkit/plugins/ppapi/webkit_forwarding_impl.cc (right):

http://codereview.chromium.org/7053022/diff/6003/webkit/plugins/ppapi/webkit_...
webkit/plugins/ppapi/webkit_forwarding_impl.cc:75: case PP_FONTFAMILY_SERIF:
Indent: need to have 2 more spaces.

[yzshen1, 2011-05-25 23:52:08]

One more comment:
I am not familiar with WebPreferences, but is it possible that the
WebPreferences at the renderer side and ppapi::Preferences at the plugin side
get out of sync? Is it serious if that happens?

[brettw, 2011-05-26 17:29:48]

I changed it so we can only set the prefs once, and added a comment explaining
the changing issue in PluginDispatcher.

http://codereview.chromium.org/7053022/diff/6003/ppapi/examples/font/simple_f...
File ppapi/examples/font/simple_font.cc (right):

http://codereview.chromium.org/7053022/diff/6003/ppapi/examples/font/simple_f...
ppapi/examples/font/simple_font.cc:96: snprintf(buf, sizeof(buf), "%s = %s
%dpt",
Darn. Since this is just an example and I'd rather keep it simple, I think I'll
just use sprintf.

http://codereview.chromium.org/7053022/diff/6003/ppapi/shared_impl/ppapi_pref...
File ppapi/shared_impl/ppapi_preferences.cc (right):

http://codereview.chromium.org/7053022/diff/6003/ppapi/shared_impl/ppapi_pref...
ppapi/shared_impl/ppapi_preferences.cc:11: Preferences::Preferences() {
Yikes!

[yzshen1, 2011-05-26 17:49:51]

LGTM

Thanks!

http://codereview.chromium.org/7053022/diff/6003/ppapi/examples/font/simple_f...
File ppapi/examples/font/simple_font.cc (right):

http://codereview.chromium.org/7053022/diff/6003/ppapi/examples/font/simple_f...
ppapi/examples/font/simple_font.cc:96: snprintf(buf, sizeof(buf), "%s = %s
%dpt",
Sounds good to me.

On 2011/05/26 17:29:49, brettw wrote:
> Darn. Since this is just an example and I'd rather keep it simple, I think
I'll
> just use sprintf.