Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 705273004: [ServiceWorker] Pass FetchEvent related properties of WebURLRequest to Blink for redirect responses. (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
Mike West, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Pass FetchEvent related properties of WebURLRequest to Blink for redirect responses. Currently SkipServiceWorker and FetchRequestMode and FetchCredentialsMode are not set correctly when performing redirects. This breaks our CORS checking functionality related to ServiceWorker's FetchEvent. I will add LayoutTests for this later. https://codereview.chromium.org/712303002/ BUG=431985 Committed: https://crrev.com/cd1e2f22cfacd026274a124d509362e02b24282b Cr-Commit-Position: refs/heads/master@{#303761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/child/web_url_loader_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
horo
mkwst@ Could you please review this?
6 years, 1 month ago (2014-11-11 02:26:59 UTC) #2
Mike West
LGTM.
6 years, 1 month ago (2014-11-11 05:48:21 UTC) #3
horo
jam@ Could you please review?
6 years, 1 month ago (2014-11-11 06:47:35 UTC) #5
jam
lgtm
6 years, 1 month ago (2014-11-11 18:22:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705273004/1
6 years, 1 month ago (2014-11-11 22:31:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-12 00:36:36 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 00:37:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cd1e2f22cfacd026274a124d509362e02b24282b
Cr-Commit-Position: refs/heads/master@{#303761}

Powered by Google App Engine
This is Rietveld 408576698