DevTools: loading timeline pretends it is recording w/ 0 events collected.

Source/devtools/front_end/timeline/TracingTimelineModel.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {!WebInspector.TracingManager} tracingManager
  * @param {!WebInspector.TracingModel} tracingModel
  * @param {!WebInspector.TimelineModel.Filter} recordFilter
  * @extends {WebInspector.TimelineModel}
@@ skipping 160 matching lines @@
             this._jsProfilerStarted = false;
         }
         this._tracingManager.stop();
     },
 
     /**
      * @param {!Array.<!WebInspector.TracingManager.EventPayload>} events
      */
     setEventsForTest: function(events)
     {
-        this._onTracingStarted();
+        this._startCollectingTraceEvents(false);
         this._tracingModel.addEvents(events);
         this._onTracingComplete();
     },
 
     _configureCpuProfilerSamplingInterval: function()
     {
         var intervalUs = WebInspector.settings.highResolutionCpuProfiling.get() ? 100 : 1000;
         this._currentTarget.profilerAgent().setSamplingInterval(intervalUs, didChangeInterval);
 
         function didChangeInterval(error)
         {
             if (error)
                 WebInspector.console.error(error);
         }
     },
 
     /**
      * @param {string} categories
      */
     _startRecordingWithCategories: function(categories)
     {
         this._tracingManager.start(categories, "");
     },
 
     _onTracingStarted: function()
     {
-        this.reset();
-        this._tracingModel.reset();
-        this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingStarted);
+        this._startCollectingTraceEvents(false);
     },
 
     /**
+     * @param {boolean} fromFile
+     */
+    _startCollectingTraceEvents: function(fromFile)
+    {
+        this.reset();
+        this._tracingModel.reset();
+        this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingStarted, fromFile);

[loislo, 2014/11/07 14:23:11]

Could you please put something more readable like {fromFile: true} instead of
plain boolean

[yurys, 2014/11/07 14:23:52]

Done.

+    },
+
+    /**
      * @param {!WebInspector.Event} event
      */
     _onEventsCollected: function(event)
     {
         var traceEvents = /** @type {!Array.<!WebInspector.TracingManager.EventPayload>} */ (event.data);
         this._tracingModel.addEvents(traceEvents);
     },
 
     _onTracingComplete: function()
     {
@@ skipping 815 matching lines @@
             lastIndex = WebInspector.TextUtils.findBalancedCurlyBrackets(data, index);
         } while (lastIndex !== -1)
 
         var json = data.slice(0, index) + "]";
         this._buffer = data.slice(index);
 
         if (!index)
             return;
 
         if (this._firstChunk) {
-            this._model._onTracingStarted();
+            this._model._startCollectingTraceEvents(true);
         } else {
             var commaIndex = json.indexOf(",");
             if (commaIndex !== -1)
                 json = json.slice(commaIndex + 1);
             json = "[" + json;
         }
 
         var items;
         try {
             items = /** @type {!Array.<!WebInspector.TracingManager.EventPayload>} */ (JSON.parse(json));
@@ skipping 221 matching lines @@
     _initializePerFrameState: function()
     {
         /** @type {!Array.<!WebInspector.InvalidationTrackingEvent>} */
         this._invalidationEvents = [];
         this._lastStyleRecalcEventIndex = 0;
         this._lastLayoutEventIndex = 0;
         this._lastPaintWithLayer = undefined;
         this._didPaint = false;
     }
 }