DevTools: loading timeline pretends it is recording w/ 0 events collected.

DevTools: loading timeline pretends it is recording w/ 0 events collected.

When loading timeline data from file the progress pane message is set to "Loading from file..."

BUG=426123
R=loislo@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184980

[yurys, 2014-11-07 14:17:49]

yurys@chromium.org changed reviewers:
+ loislo@chromium.org

[loislo, 2014-11-07 14:23:11]

lgtm with nits

https://codereview.chromium.org/705273002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TracingTimelineModel.js (right):

https://codereview.chromium.org/705273002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:218:
this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingStarted,
fromFile);
Could you please put something more readable like {fromFile: true} instead of
plain boolean

[yurys, 2014-11-07 14:23:52]

https://codereview.chromium.org/705273002/diff/1/Source/devtools/front_end/ti...
File Source/devtools/front_end/timeline/TracingTimelineModel.js (right):

https://codereview.chromium.org/705273002/diff/1/Source/devtools/front_end/ti...
Source/devtools/front_end/timeline/TracingTimelineModel.js:218:
this.dispatchEventToListeners(WebInspector.TimelineModel.Events.RecordingStarted,
fromFile);
On 2014/11/07 14:23:11, loislo wrote:
> Could you please put something more readable like {fromFile: true} instead of
> plain boolean

Done.

[yurys, 2014-11-07 14:25:11]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-11-07 14:25:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/705273002/20001

[commit-bot: I haz the power, 2014-11-07 16:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-07 16:52:24]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/35353)

[yurys, 2014-11-07 17:24:50]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2014-11-07 17:25:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/705273002/20001

[yurys, 2014-11-07 17:31:57]

Committed patchset #2 (id:20001) manually as 184980 (presubmit successful).