Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 705183002: Mesa ES 3.0 requires sized internal formats (Closed)

Created:
6 years, 1 month ago by derekf
Modified:
6 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Mesa ES 3.0 requires sized internal formats Mesa's ES 3.0 implementation requires GL_R8 as an internal format instead of GL_RED Committed: https://skia.googlesource.com/skia/+/32f80ca3821947494e1e81e31896412c098562b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/gpu/gl/GrGpuGL.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
derekf
In fact, I'm not certain the ES spec allows GL_RED as an internalformat directly at ...
6 years, 1 month ago (2014-11-06 21:55:04 UTC) #2
bsalomon
lgtm
6 years, 1 month ago (2014-11-07 14:20:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705183002/1
6 years, 1 month ago (2014-11-07 17:31:35 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 17:39:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/32f80ca3821947494e1e81e31896412c098562b5

Powered by Google App Engine
This is Rietveld 408576698