Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: minidump/minidump_extensions.h

Issue 705153002: Add list_annotations to MinidumpModuleCrashpadInfo (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@minidump_string_list_writer
Patch Set: Rebase Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | minidump/minidump_module_crashpad_info_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: minidump/minidump_extensions.h
diff --git a/minidump/minidump_extensions.h b/minidump/minidump_extensions.h
index 70539ebed0343b7ded7fdde1d5e6ba58f605291b..a82d2f96562e522e5f42121ab7951b19d6cd3425 100644
--- a/minidump/minidump_extensions.h
+++ b/minidump/minidump_extensions.h
@@ -374,9 +374,22 @@ struct __attribute__((packed, aligned(4))) MinidumpModuleCrashpadInfo {
//! This field is present when #version is at least `1`.
uint32_t minidump_module_list_index;
+ //! \brief A MinidumpRVAList pointing to MinidumpUTF8String objects. The
+ //! module controls the data that appears here.
+ //!
+ //! These strings correspond to ModuleSnapshot::AnnotationsVector() and do not
+ //! duplicate anything in #simple_annotations.
+ //!
+ //! This field is present when #version is at least `1`.
+ MINIDUMP_LOCATION_DESCRIPTOR list_annotations;
+
//! \brief A MinidumpSimpleStringDictionary pointing to strings interpreted as
//! key-value pairs. The module controls the data that appears here.
//!
+ //! These key-value pairs correspond to
+ //! ModuleSnapshot::AnnotationsSimpleMap() and do not duplicate anything in
+ //! #list_annotations.
+ //!
//! This field is present when #version is at least `1`.
MINIDUMP_LOCATION_DESCRIPTOR simple_annotations;
};
« no previous file with comments | « no previous file | minidump/minidump_module_crashpad_info_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698