Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 705093005: Add C++11 enum class support to the Java enum class generator. (Closed)

Created:
6 years, 1 month ago by mkosiba (inactive)
Modified:
6 years, 1 month ago
Reviewers:
cjhopman, jdduke (slow)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add C++11 enum class support to the Java enum class generator. This adds support for the enum class/struct construct as well as limited support for fixed types (currently only types that convert to jint are supported). BUG=None TESTS=java_cpp_enum_tests Committed: https://crrev.com/7fd46f236b16d0dee58a8e0f007029912dea4d9f Cr-Commit-Position: refs/heads/master@{#303332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -10 lines) Patch
M build/android/gyp/java_cpp_enum.py View 4 chunks +19 lines, -3 lines 0 comments Download
M build/android/gyp/java_cpp_enum_tests.py View 1 chunk +72 lines, -0 lines 0 comments Download
M build/android/pylib/constants.py View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mkosiba (inactive)
6 years, 1 month ago (2014-11-07 05:07:44 UTC) #2
jdduke (slow)
<24 hour turnaround time, you're my hero. As a non-owner not super familiar with this ...
6 years, 1 month ago (2014-11-07 16:03:34 UTC) #3
cjhopman
lgtm
6 years, 1 month ago (2014-11-07 22:31:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705093005/1
6 years, 1 month ago (2014-11-07 22:52:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-08 00:14:24 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 00:15:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fd46f236b16d0dee58a8e0f007029912dea4d9f
Cr-Commit-Position: refs/heads/master@{#303332}

Powered by Google App Engine
This is Rietveld 408576698