DescriptionEnable zlib SIMD optimisations on Mac OS X builds
With ninja builds generated from gyp on a Mac it is necessary to specify the
cflags to use as EXTRA_CFLAGS in an xcode_settings block in the gyp file. With
gn this is not necessary and led to confusion resulting in Mac builds not being
enabled in the original CL. As all Intel based Mac systems have SSE2 the
compiler does not require "-msse2" as it can always use that.
This change also initialised the global variables, as a result the variable is
moved from being a common symbol to being in the BSS section of the library.
This is necessary as unfortunately the linker on Mac cannot handle common
symbols with static libraries.
blink layout test inspector/layers/layer-canvas-log.html may start failing on
Mac with this change (See BUG below)
TEST=Build on Mac OS X and net_unittests --gtest_filter=*Compressed* run and
uses optimised code paths
BUG=430557
Committed: https://crrev.com/01686c1a7b233fcb8ab16b41ad3ffe58aef09cd1
Cr-Commit-Position: refs/heads/master@{#304089}
Patch Set 1 #Patch Set 2 : Keep disabled on ios; initialise symbols so we're in the BSS #
Messages
Total messages: 7 (2 generated)
|