Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 704963002: Make some arguments of FocusController functions references. (Closed)

Created:
6 years, 1 month ago by tkent
Modified:
6 years, 1 month ago
Reviewers:
tasak, kochi
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Project:
blink
Visibility:
Public.

Description

Make some arguments of FocusController functions references. We can remove unnecessary assertions and runtime null checks by this change. BUG= TEST=none; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -77 lines) Patch
M Source/core/dom/Element.h View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/page/FocusController.h View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/page/FocusController.cpp View 17 chunks +65 lines, -72 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tkent
Kochi-san or Hayato-san, would you review this please?
6 years, 1 month ago (2014-11-06 03:05:09 UTC) #2
kochi
lgtm
6 years, 1 month ago (2014-11-06 03:59:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/704963002/1
6 years, 1 month ago (2014-11-06 04:02:53 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 04:04:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184893

Powered by Google App Engine
This is Rietveld 408576698