Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: components/copresence/handlers/directive_handler_unittest.cc

Issue 704923002: Add polling and audio check to copresence. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/copresence/handlers/directive_handler_unittest.cc
diff --git a/components/copresence/handlers/directive_handler_unittest.cc b/components/copresence/handlers/directive_handler_unittest.cc
index 09de7ea23570c3f0d3687b5b23ea377f81c1e09d..30a0a9672d2afa00e287bcc1ea54e6dd25107e38 100644
--- a/components/copresence/handlers/directive_handler_unittest.cc
+++ b/components/copresence/handlers/directive_handler_unittest.cc
@@ -35,9 +35,8 @@ class FakeAudioDirectiveHandler final : public AudioDirectiveHandler {
public:
FakeAudioDirectiveHandler() {}
- void Initialize(
- const AudioManager::DecodeSamplesCallback& /* decode_cb */,
- const AudioManager::EncodeTokenCallback& /* encode_cb */) override {}
+ void Initialize(WhispernetClient* /* whispernet_client */,
+ const TokensCallback& /* tokens_cb */) override {}
void AddInstruction(const TokenInstruction& instruction,
const std::string& /* op_id */,
@@ -54,6 +53,11 @@ class FakeAudioDirectiveHandler final : public AudioDirectiveHandler {
return "";
}
+ bool IsPlayingTokenHeard(AudioType /* type */) const override {
+ NOTREACHED();
+ return false;
+ }
+
const std::vector<std::string>& added_tokens() const {
return added_tokens_;
}
@@ -90,7 +94,7 @@ TEST_F(DirectiveHandlerTest, Queuing) {
EXPECT_THAT(audio_handler_->added_tokens(), IsEmpty());
EXPECT_THAT(audio_handler_->removed_operations(), IsEmpty());
- directive_handler_.Start(whispernet_client_.get());
+ directive_handler_.Start(whispernet_client_.get(), TokensCallback());
directive_handler_.RemoveDirectives("id 3");
EXPECT_THAT(audio_handler_->added_tokens(), ElementsAre("token 3"));

Powered by Google App Engine
This is Rietveld 408576698